aboutsummaryrefslogtreecommitdiff
path: root/src/Remember.cc
diff options
context:
space:
mode:
authorPavel Labath <pavelo@centrum.sk>2011-07-02 15:21:24 (GMT)
committerPavel Labath <pavelo@centrum.sk>2011-11-01 09:57:20 (GMT)
commitf2709b26d8af7292f750fc05525ac90ad0d99c41 (patch)
tree794903544922abe2b90af6250de24124cd94d546 /src/Remember.cc
parent0584414d3845239202d5ea02da2ce6fb5b1b0cbb (diff)
downloadfluxbox_pavel-f2709b26d8af7292f750fc05525ac90ad0d99c41.zip
fluxbox_pavel-f2709b26d8af7292f750fc05525ac90ad0d99c41.tar.bz2
Store menus if smart pointers (RefCount)
This was originally intended to be a bugfix for an memory error reported by valgrind (accessing freed memory). While debugging it, I found the menu ownership semantics confusing (setInternalMenu() et al.), so I decided to get rid of it and store it in smart pointers everywhere. Looking back, I'm not sure if this was worth all the trouble, but the good news is that the valgrind error disappeared. :)
Diffstat (limited to 'src/Remember.cc')
-rw-r--r--src/Remember.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/Remember.cc b/src/Remember.cc
index 10aa52c..c010d07 100644
--- a/src/Remember.cc
+++ b/src/Remember.cc
@@ -302,10 +302,10 @@ private:
302 Remember::Attribute m_attrib; 302 Remember::Attribute m_attrib;
303}; 303};
304 304
305FbTk::Menu *createRememberMenu(BScreen &screen) { 305FbTk::RefCount<FbTk::Menu> createRememberMenu(BScreen &screen) {
306 // each fluxboxwindow has its own windowmenu 306 // each fluxboxwindow has its own windowmenu
307 // so we also create a remember menu just for it... 307 // so we also create a remember menu just for it...
308 FbTk::Menu *menu = screen.createMenu("Remember"); 308 FbTk::RefCount<FbTk::Menu> menu( screen.createMenu("Remember") );
309 309
310 // if enabled, then we want this to be a unavailable menu 310 // if enabled, then we want this to be a unavailable menu
311 /* 311 /*