diff options
author | Ryan Pavlik <rpavlik@iastate.edu> | 2011-11-02 17:33:38 (GMT) |
---|---|---|
committer | Mathias Gumz <akira at fluxbox dot org> | 2012-01-04 06:53:54 (GMT) |
commit | 5ae8bdf49db36b2691ce545e3285f9ee64f92148 (patch) | |
tree | 5ef8285a7f6c54a35544903c05018fd0445aee30 /src/FocusableList.cc | |
parent | f859e78cb24cf69cc06e4395c58d804537f301c7 (diff) | |
download | fluxbox_pavel-5ae8bdf49db36b2691ce545e3285f9ee64f92148.zip fluxbox_pavel-5ae8bdf49db36b2691ce545e3285f9ee64f92148.tar.bz2 |
Pre-increment non-primitive types.
Found with cppcheck:
"Prefix ++/-- operators should be preferred for non-primitive
types. Pre-increment/decrement can be more efficient than
post-increment/decrement. Post-increment/decrement usually
involves keeping a copy of the previous value around and adds
a little extra code."
Diffstat (limited to 'src/FocusableList.cc')
-rw-r--r-- | src/FocusableList.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/FocusableList.cc b/src/FocusableList.cc index 382a6f5..87c5bcc 100644 --- a/src/FocusableList.cc +++ b/src/FocusableList.cc | |||
@@ -169,7 +169,7 @@ bool FocusableList::insertFromParent(Focusable &win) { | |||
169 | Focusables::iterator our_it = m_list.begin(), our_it_end = m_list.end(); | 169 | Focusables::iterator our_it = m_list.begin(), our_it_end = m_list.end(); |
170 | // walk through our list looking for corresponding entries in | 170 | // walk through our list looking for corresponding entries in |
171 | // parent's list, until we find the window that moved | 171 | // parent's list, until we find the window that moved |
172 | for (; our_it != our_it_end && p_it != p_it_end; p_it++) { | 172 | for (; our_it != our_it_end && p_it != p_it_end; ++p_it) { |
173 | if (*p_it == &win) { | 173 | if (*p_it == &win) { |
174 | if (*our_it == &win) // win didn't move in our list | 174 | if (*our_it == &win) // win didn't move in our list |
175 | return false; | 175 | return false; |