Refactor menu code: be more explicit and compact

This commit is a preparation step for some menu cleanup ahead. To make it
easier to understand which types of MenuItems are added where and when, I
converted the overloaded FbTk::Menu::insert() functions into explicit ones
(Menu::insertSubmenu(), Menu::insertItem(), etc. ). This makes it possible
to just grep for 'insertSubmenu()'.

Side effect this commit: it trims down the very verbose creation of menu items
in regards to how the labels are created.

Minor: FbTk::Menu::shown and FbTk::Menu::s_focused are moved out of the class.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/SendToMenu.cc b/src/SendToMenu.cc
index afdc854..120a939 100644
--- a/src/SendToMenu.cc
+++ b/src/SendToMenu.cc
@@ -84,12 +84,12 @@ void SendToMenu::rebuildMenu() {
     for (size_t i = 0; i < wlist.size(); ++i) {
         FbTk::RefCount<FbTk::Command<void> > sendto_cmd(new SendToCmd(i, false));
         FbTk::RefCount<FbTk::Command<void> > sendto_follow_cmd(new SendToCmd(i, true));
-        
+
         FbTk::MultiButtonMenuItem* item = new FbTk::MultiButtonMenuItem(3, wlist[i]->name());
         item->setCommand(1, sendto_cmd);
         item->setCommand(2, sendto_follow_cmd);
         item->setCommand(3, sendto_cmd);
-        insert(item);
+        insertItem(item);
     }
 
     updateMenu();