Fix segfault on shutdown

There was a problem deep within how the menus were connected and when and
what gets deleted. It was clearly related to a menu which was kind of
global. In order to better understand the code flow I eliminated the
ExtraMenu code: it was used only to get the Remember-Menu into the
Window-Menu. Instead of having a singleton of the Remember-Menu and fight
against the shaky interconnections we just create a new one on demand
and delete when the menu gets deleted. Looks like this fixes the problem.

The menu code needs more love anyway.

Closes #1118

1 files changed, 3 insertions, 0 deletions

diff --git a/src/Remember.hh b/src/Remember.hh
index a1abf5a..a6a980e 100644
--- a/src/Remember.hh
+++ b/src/Remember.hh
@@ -41,6 +41,7 @@ class Application;
 
 namespace FbTk {
 class AutoReloadHelper;
+class Menu;
 }
 
 /**
@@ -125,6 +126,8 @@ public:
 
     void initForScreen(BScreen &screen);
 
+    static FbTk::Menu* createMenu(BScreen& screen);
+
     // Functions we ignore (zero from AtomHandler)
     // Leaving here in case they might be useful later