diff options
author | Mathias Gumz <akira@fluxbox.org> | 2015-01-03 17:45:28 (GMT) |
---|---|---|
committer | Mathias Gumz <akira@fluxbox.org> | 2015-01-03 17:45:28 (GMT) |
commit | 65e06542491375953a481aee3f99ad412721b2d4 (patch) | |
tree | 7c151d92b8b1ca01270bf554b2031905405c50cc /src/FbTk | |
parent | bd519dd95200aa432fb3b431a4244ffb25c5de93 (diff) | |
download | fluxbox-65e06542491375953a481aee3f99ad412721b2d4.zip fluxbox-65e06542491375953a481aee3f99ad412721b2d4.tar.bz2 |
Fix typo / editor bug or something like that.
While running code analysis tools this issue popped up. As it is written it is
clearly a NOP, but the reason for why it is written that way remains unknown.
I suspect that it was a textfragment introduced by some repeat-function of the
used editor (think '.' in VIM). The code was introduced by commit a932a7a801
and looked like this in the original form:
if(!XQueryTree(FbTk::App::instance()->display(), window().window(),
&root_return, &parent_return,
&children_return, &nchildren_return))
parent_return=parent_return;//return;
Look at the outcommented return statement. I decided to return from that
function instead of the NOP.
Diffstat (limited to 'src/FbTk')
-rw-r--r-- | src/FbTk/Container.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/FbTk/Container.cc b/src/FbTk/Container.cc index b944c98..9ccae92 100644 --- a/src/FbTk/Container.cc +++ b/src/FbTk/Container.cc | |||
@@ -129,7 +129,7 @@ bool Container::moveItemTo(Item item, int x, int y) { | |||
129 | // get the root window | 129 | // get the root window |
130 | if (!XQueryTree(display(), window(), | 130 | if (!XQueryTree(display(), window(), |
131 | &root_return, &parent_return, &children_return, &nchildren_return)) | 131 | &root_return, &parent_return, &children_return, &nchildren_return)) |
132 | parent_return = parent_return; | 132 | return false; |
133 | 133 | ||
134 | if (children_return != NULL) | 134 | if (children_return != NULL) |
135 | XFree(children_return); | 135 | XFree(children_return); |