Make RefCount<> more sensible

the previous version of operator*() made no sense. E.g., it violated the invariant
(*ptr).foo <=> ptr->foo. The dereferencing operator now returns a reference to the pointed-to
object, rather than a pointer to it.

I also added a bool conversion operator, which can be used in testing the NULL-ness of the
pointer. Anyone wondering if that could be done in a simpler way is encouraged to read
<http://www.artima.com/cppsource/safebool.html>.

And, finally, I removed the mutable flag from the m_data member, since it does not need it.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/FbTk/LogicCommands.cc b/src/FbTk/LogicCommands.cc
index b3abe31..bda67f5 100644
--- a/src/FbTk/LogicCommands.cc
+++ b/src/FbTk/LogicCommands.cc
@@ -44,7 +44,7 @@ M *addCommands(M *macro, const string &args, bool trusted) {
     std::vector<std::string>::iterator it = cmds.begin(), it_end = cmds.end();
     for (; it != it_end; ++it) {
         cmd = CommandParser<bool>::instance().parse(*it, trusted);
-        if (*cmd)
+        if (cmd)
             macro->add(cmd);
     }
 
@@ -91,13 +91,13 @@ Command<void> *IfCommand::parse(const std::string &command, const std::string &a
         return 0;
 
     cond = CommandParser<bool>::instance().parse(cmds[0], trusted);
-    if (*cond == 0)
+    if (cond == 0)
         return 0;
 
     t = CommandParser<void>::instance().parse(cmds[1], trusted);
     if (cmds.size() >= 3)
         f = CommandParser<void>::instance().parse(cmds[2], trusted);
-    if (*t == 0 && *f == 0)
+    if (t == 0 && f == 0)
         return 0;
 
     return new IfCommand(cond, t, f);