Refactor menu code: be more explicit and compact

This commit is a preparation step for some menu cleanup ahead. To make it
easier to understand which types of MenuItems are added where and when, I
converted the overloaded FbTk::Menu::insert() functions into explicit ones
(Menu::insertSubmenu(), Menu::insertItem(), etc. ). This makes it possible
to just grep for 'insertSubmenu()'.

Side effect this commit: it trims down the very verbose creation of menu items
in regards to how the labels are created.

Minor: FbTk::Menu::shown and FbTk::Menu::s_focused are moved out of the class.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/ClientMenu.cc b/src/ClientMenu.cc
index 96527ec..84f2025 100644
--- a/src/ClientMenu.cc
+++ b/src/ClientMenu.cc
@@ -118,9 +118,9 @@ void ClientMenu::refreshMenu() {
             FluxboxWindow::ClientList::iterator client_it_end =
                 win->clientList().end();
             for (; client_it != client_it_end; ++client_it)
-                insert(new ClientMenuItem(**client_it, *this));
+                insertItem(new ClientMenuItem(**client_it, *this));
         } else
-            insert(new ClientMenuItem(**win_it, *this));
+            insertItem(new ClientMenuItem(**win_it, *this));
     }
 
     updateMenu();