aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-01-18bug fix: make fluxbox work under nxserver, closes #2813828Mathias Gumz1-0/+50
nxserver-3.x creates a XExposeEvent for the unmapped FbTk::Menu(), which is not configured completely yet (hence unmapped). this causes a call to FbTk::Menu::clearItem() which then uses a value of 0 for m_rows_per_column to divide the current index which triggers a SIGFPE. it is still unclear, why nxserver-3.x creates the XExposeEvent for the unmapped (menu) window. doing nothing if the menu is unmapped 'fixes' the problem for now. many thanks to Lars Engels (bsd-geek.de) to assist me in debugging this issue.
2011-01-16compile fix, new name of setMinimumSublevels() is setMinimumColumns()Mathias Gumz1-1/+1
2011-01-15removed useless include statementsMathias Gumz1-4/+0
'typeinfo' was needed for RTTI in isItemSelectable() (see last commit) 'algorithm' is already included some lines above
2011-01-15better use of API, no need for 'timeval' in MenuMathias Gumz1-4/+1
2011-01-15MenuItem::isEnabled() is sufficient to decide Menu::isItemSelectable()Mathias Gumz1-3/+1
MenuSeparator is never enabled since it returns always 'false' in its implementation of isEnabled(). no need to use RTTI imho.
2011-01-15small refactoring of FbTk/Menu codeMathias Gumz4-229/+254
* removed useless struct _menu * code deduplication via renderMenuPixmap() * improved documentation: - 'sublevel' actually means 'column' - 'persub' means 'row_per_column'
2011-01-13compile fix: missing symbol (SystemTray::getNetSystemTray()) when configured ↵Mathias Gumz1-1/+4
--disable-toolbar
2011-01-06updated ChangelogMathias Gumz1-0/+21
2011-01-06bugfix: do not assume ':number.screen' as the result of 'DisplayString()'Mathias Gumz1-4/+15
a newer xlib recently changed the result of 'DisplayString()' a little bit: instead of returning ':0.0' or ':1.0' it yields ':0' or ':1'. our code to transform this string into something that includes the currently used Screen worked only on something like ':0.0'. we now find the '.' after the ':' and strip that part away.
2010-10-13bugfix: std::string() does not like NULL on constructionMathias Gumz1-6/+19
not having DISPLAY set (eg: on a headless system) caused fluxbox to crash.
2010-09-20use 'system()' to run 'fluxbox-update_configs'Mathias Gumz1-3/+1
by using FbCommands::ExecureCmd() we run 'fluxbox-update_configs' in the bacground while booting a new fluxbox instance already. 'system()' waits until 'fluxbox-update_configs' is done and then gives the control back to fluxbox.
2010-09-20updated 'texturetest.cc' to work with current APIMathias Gumz1-4/+6
2010-09-20bugfix: ' floating point exception' due wrongly placed codeMathias Gumz1-1/+2
while integrating the old 'getSqrt()' function into the 'bsqrt()' function i misplaced some code. this lead to 'r' being 0 on the first run. doh.
2010-09-19upgrade default 'init' file to reflect current configVersionMathias Gumz1-1/+1
2010-09-19updated ChangeLogMathias Gumz1-6/+107
2010-09-19merged conflictsMathias Gumz0-0/+0
2010-09-19pushed to early ...Mathias Gumz1-16/+64
2010-09-19compile fix: use 'CallMemFunWithRefArg' instead of bind2nd(mem_fun(), *foo)Mathias Gumz1-16/+65
g++-4.1 does not like parts of 12e1ef78265a621dc51f7b9af245d81431835dcc, calling std::bind2nd(std::mem_fun(func), ref_arg) lead to a bunch of error: forming reference to reference type 'XYZ' in order to avoid switching either back to the old for-loops or boost::bind or to enforce a newer compiler (eg, g++-4.4) to the users a new helper functor was created: 'CallMemFunWithRefArg' this commit also fixes a little copy and paste error introduced in 12e1ef782, 'AtomHandler::updateClientClose' was called instead of 'AtomHandler::updateWorkspace'.
2010-09-18changed the way we create the '~/.fluxbox' directory to avoid race conditionsMathias Gumz5-104/+141
before bringing up the first instance of Fluxbox we prepare the directory and the files it needs. if the config version of exiting files is lower than what we expect, we upgrade the config files. after that we bring up Fluxbox. the old way was problematic because setupConfigFiles() calls 'fluxbox-update_configs' which does its job in the background while fluxbox continues to boot. 'fluxbox-update_configs' sends a USR2 signal to the booting fluxbox (it might even be finished, no one knows) which triggers 'load_rc()' which triggered 'setupConfigFiles()' again which might trigger 'fluxbox-update_configs' again (on my machine 'fluxbox-update_configs' was called 3 times and left a pretty crippled 'keys' file when it was done). bootstrapping before bringing up fluxbox resolves the issue. as a bonus: no need to send USR2 to fluxbox to reload the config file because fluxbox has not even tried to read it yet.
2010-09-18cosmeticMathias Gumz3-64/+121
2010-09-18recovered lost change from 041d586972db4da170123f5468d7b11d4eda8ae5Mathias Gumz1-96/+65
got lost in d3eabeb805fdbd162c0743ed86a67e014e37c097 somehow
2010-09-17bugfix: avoid naive use of 'putenv' by providing 'FbTk::App::setenv()'Mathias Gumz4-36/+66
to quote from 'man putenv': The string pointed to by string becomes part of the environment, so altering the string changes the environment. so, using putenv like { std::string foo("FOO=bar"); putenv(foo.c_str()); } is wrong and leads to a potentially corrupted environment. valgrind complaint correctly. FbTk::App seems to be the appropriate place to hold '::seten()' because it alters the environment of the application.
2010-09-17missing initializationsMathias Gumz3-1/+4
'valgrind' reported a lot of code branches based upon uninitialized variables. some are not identified yet.
2010-09-17request explicitly as many elements for the gradient tables as we needMathias Gumz2-18/+8
the next step is to not use 'unsigned int' and then only store 'chars' in it, maybe even using RGBA data instead of separated arrays for r, g and b.
2010-09-17bugfix: forgot to resize 'pixels' before putting values into it (facepalm)Mathias Gumz1-2/+2
2010-09-17added 'ArrangeWindowsVertical' to actionsJohn K Pate3-8/+28
2010-09-17moved commandline parsing to its own functionMathias Gumz2-86/+132
2010-09-17lots of code cleanup, reordering, trimming public API, bugfixesMathias Gumz4-896/+918
## FbTk/ImageControl.hh: * moved 'getSqrt()' over to TextureRender.cc because it is used only there * removed unused members m_root_window * use std::vector<> for colors and for the gradient buffers. ## FbTk/ImageControl.cc: * fixed memory leak in '~ImageControl', 'pixels' where not deleted[] at all. switched to std::vector, non-issue anymore. * moved identical code into functions 'allocateUnallocatedColors', 'initColortables' ## FbTk/TextureRenderer: * removed 'from', 'to', 'interlaced' from class, only used in 'renderGradient()' and are actually part of the given texture. * removed 'xtable', 'ytable' from class, only used in 'renderGradient()' * removed 'colors' from the class, is part of 'control' * moved render actions (invert, bevel1, bevel2, *gradient), they need more love but for now this is sufficient
2010-09-17use FbTk::API to reduce code duplicationMathias Gumz3-22/+34
2010-09-17code simplification by reducing if-else hellMathias Gumz4-164/+110
a lot of the parsing-related and menu-building stuff is just plain stupid boiler plate code. putting the data into a const array separates the boiler plate data from the actual code.
2010-09-15use hardcoded array for hardcoded placement menu defaultsMathias Gumz1-30/+28
2010-09-15removed useless codeMathias Gumz1-4/+0
'tools' is transformed to lower case some lines above, 'm_tools_ is a copy of the lower cased 'tools'.
2010-09-15code deduplication by using <algorithm> and FbTk/STLUtil.hhMathias Gumz1-17/+8
2010-09-15code deduplication by using <algorithm> and FbTk/STLUtil.hhMathias Gumz6-168/+104
2010-09-14code cleanup, missing commit for 2b62cf973318978bc222db7719552148275887dbMathias Gumz1-30/+23
2010-09-14bugfix: 'reset' nr_shapes to '0' after last instance of 'Shape'Mathias Gumz1-1/+3
2010-09-14cleanup and code deduplicationMathias Gumz5-51/+54
* ClientPattern.cc: make compiler happy (complaints about XPROP not handled in switch) * FbTk/FbPixmap.cc FbTk/StringUtil.cc: signed vs unsigned * FbTk/FbString.cc: missing return * WinClient.cc: create atoms only once; use helper function * Window.cc: use a helper function
2010-09-14use one array instead of two to hold both 'names' and 'atoms' for the rootwindowMathias Gumz1-30/+29
2010-09-14bugfix: create the corner pixmaps only once per screenMathias Gumz1-14/+29
for each window (windows, menue etc) the initCorners() function of FbTk/Shape.cc was called (which is ok). On each call the corner pixmaps (of the Screen the window belongs to) were created and destroyed the formerly created pixmaps. this is not needed.
2010-09-14bugfix: free the shape-corners on the last used 'Shape'Mathias Gumz1-1/+1
the global 's_corners' vector was still used on an application shutdown (including ctrl-c SIGINT). depending on when 's_corners' was created on the stack this could lead to an exception ('pure virtual called') while trying to free the 'FbPixmaps' without having a valid 'FbTk::Application::instance()' left.
2010-09-14bugfix: small typo in last cleanup prevented loading workspace namesMathias Gumz1-1/+1
2010-09-13cosmetic code cleaningMathias Gumz2-47/+33
* use FbTk::StringUtil::number2String() to avoid 'sprintf' * use FbTk::Util::clamp() * use FbTk::STLUtil::destroyAndClear() * whitespaces
2010-09-13code simplificationMathias Gumz7-62/+56
we do not need a std::map just to store an attribute on an AtomHandler, it makes housekeeping just more annoying.
2010-09-13code simplificationMathias Gumz1-56/+28
2010-09-11updated config version to '13' and adjusted 'fluxbox-update_configs' accordinglyMathias Gumz2-301/+473
our users should migrate seamlessly to our new windows-cycling behaviour without losing their current way of doing things. so, 'fluxbox-update_configs' tries its best to add '(workspace=[current])' wherever it looks like a valid place for it. such changed lines are marked by '!! FBCV13' at the end and can be easily spotted in case the updater got it wrong. addtional changes: * added '-check' to 'fluxbox-update_configs' to check the version number in '~/.fluxbox/init' vs. the version number of 'fluxbox-update_configs' * moved the update-code for each version into its own function, easier housekeeping
2010-09-11added '(workspace=[current])' to our default keysMathias Gumz2-4/+4
commit 882a50fe1d4930b156965c54d9b66ecb27b4c9b2 removed the hardcoded limit to cycle to windows on other workspaces, though it was and IS a good default behaviour. if users do not want this (they want to cycle to windows on other workspaces), they should explicitly avoid '(workspace=[current])' in their keysfile.
2010-09-11added 'SetXProp' action and (@PROP=foo) clientpatternMathias Gumz9-83/+206
these two allow 'tagging' of arbitrary windows with 'tags' (or 'labels'). such 'tagged' windows can then be used in ':NextWindow (@PROP=foo)' commands to quickly cycle through a subset of available windows. since the 'tags' are applied as real xproperties to a window they survive a restart of fluxbox or even another windowmanager. the user can also set the tags by using xprop(1). the next step regarding the UI should be to visualize the tags of a window.
2010-09-10moved helper struct TextPropPtr into anonymous namespaceMathias Gumz1-0/+4
2010-09-10code cleanupMathias Gumz2-55/+57
* moved code from public API to internals * avoid code duplication ( while(!m_terms.empty()) ...) * cosmetic '(*it)->' vs 'term.'
2010-09-10removed hardcoded limitation to cycle/focus windows on all workspacesMathias Gumz1-3/+1
reasons: * fixes #1732115, allows to have chatwindows on another workspaces and reach them via :NextWindow (urgent=yes) * old behavior can be achieve by using the (workspace=[current]) pattern
generated by cgit v0.11.2 at 2024-11-19 12:27:36 (GMT)