aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-09-14Use RefCount to store keybindingsPavel Labath2-58/+39
I'm doing this because I want to have access to keybindings from lua and for that I need more flexible ownership semantics.
2011-09-14Remove the assignment operator from a regular pointer to a RefCountPavel Labath5-11/+9
it is too easy too shoot yourself in the foot with it, other smart pointers also don't allow such assignments. If you do want to assign to a RefCount pointer, use reset(). ps: assignment between two RefCounts remains possible, of course.
2011-09-14Remove obsolete codePavel Labath1-8/+0
ps: it was already commented out, I'm just deleting it
2011-09-14add FbTk::makeRef function, for easier construction of RefCount pointersPavel Labath1-0/+20
2011-09-14FbTk::Timer accepts Slots instead of Commands as the former are more generalPavel Labath2-8/+8
2011-09-14Signal::connect now also accepts an already-constructed SlotPavel Labath1-3/+27
This way we can use Commands as signal handlers out-of-the-box.
2011-09-14Make FbTk::Command inherit from FbTk::SlotPavel Labath1-3/+8
Command offers a subset of functionality and could be completely removed at some point.
2011-09-14Fix a small bug in BScreen constructorPavel Labath1-1/+1
it was testing for FbWindow.property() == Success, where it should've tested for == true.
2011-09-14Add a reset() function to FbTk::RefCountPavel Labath1-0/+1
to make it's interface more compatible with other smart pointers.
2011-09-14Mark FbTk::StringConvertor as NotCopyablePavel Labath1-1/+3
2011-09-14Prepare the Slot classes to be used independently of SignalsPavel Labath2-64/+117
Added some polish around them and, to mark this special occasion, moved them out of the SigImpl namespace. PS: This partially reverts commit 0775350fee345e37fb59835dda4d85664346b606, since I had to reintroduce ReturnType template parameter, because it will be used in other places. But Signal classes remain without the ReturnType, because I still cannot imagine how would it be used.
2011-09-14Add template copy constructor to FbTk::RefcountPavel Labath1-2/+8
and remove a an "almost" copy constructor (almost, because it takes a non-const reference parameter) which was useless.
2011-09-11FbString: fix build without iconvPeter Korsgaard1-1/+2
Commit 690d926 (introduced FbTk::BidiString) broke building without HAVE_ICONV, because of wrong variable name and use of iconv_t type. Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2011-09-10sync the copied config files to disk before continuingMathias Gumz1-0/+11
otherwise a race condition might appear between copying the default config files to .fluxbox/ and executing 'fluxbox-update_configs'. under macosx this lead to 'fluxbox hangs'.
2011-09-02Rebuilding the fluxbox docs to change fix a small grammer mistakePaul Tagliamonte11-87/+138
Fluxbox's man page had "allows to", which should actually be something like "allows one to". The rest of the .ins were rebuilt as a result. No changes otherwise.
2011-09-01Re-licensing the ostrich theme due to issues regarding it's distributionSven Michel1-3/+1
CC-BY-NC 3.0 is a great license, but it limits how well we can redistribute the theme it's self. This change allows distros (such as Debian) to keep this theme in the source.
2011-09-01bugfix: do not change workspaces when using NextWindow / PrevWindow buttons ↵Mathias Gumz1-3/+8
in toolbar
2011-08-26regrab ButtonMotionMask as well (needed for 'Move' events in keysfile)Mathias Gumz1-1/+1
2011-08-26bugfix: remap keysyms to keycodes after 'MappingNotify', fix #3386257Mathias Gumz1-11/+25
setxkbmap and xmodmap both might change the keycodes. thus fluxbox needs to remap the keysyms from the currently loaded keytree to new keycodes after it received a 'MappingNotify' event. we do not reload() the keys file because: * the user might work on it right now * remap only needed symbols is cheaper than parsing the keysfile anyway
2011-08-11Updated styles 'bloe' and 'arch' to look better without xpm-supportSven Michel2-87/+87
2011-08-11Use _NET_WM_ICON from 32bit apps (xfce4-terminal) correctlyMathias Gumz1-3/+13
The icons coming from _NET_WM_ICON are argb32. fluxbox uses such icons in entities such as 'clientmenu', 'iconbar', 'titlebar'. These entities are not related to the depth of the winclient but to fluxbox's default depth. Using 'winclient.depth()' is a mistake, since fluxbox is unable to copy pixmaps from 32bit to 24/16/15bit. It is not necessary either, because fluxbox should extract the argb32 icon data directly into the pixmap with the correct depth in the first place. This fixes (reopened) bug #1852693. Note: The whole icon code in fluxbox is quite messy, lots of copying and scaling. It might be simpler and fater to just extract the icon when needed , in just the size that is needed.
2011-05-16TextDialog now handles parentrelative labelsnacitar sevaht1-11/+20
Prior to this patch, TextDialog did not handle parentrelative labels; borrowing code from OSDWindow, now TextDialog properly handles this. Eventually, I plan to combine the good parts of TextDialog and OSDWindow into OSDWindow, and then let TextDialog derive from OSDWindow... but for now, here's the band-aid fix for the issue without the refactorization.
2011-05-16TextDialog and ToolTipWindow style rendering bugs fixednacitar sevaht2-11/+17
TextDialog windows (such as 'set title', or 'edit clock format') now properly render their titlebar to match the current style. Previously, the titlebar font settings were controlled by window.font.*, and this became apparent because window.font.effect needed to be set to put 'halo' on the titlebar of these TextDialogs. However, window.font.effect controls the effect on the text within the editbox on these as well, having these set in the same location is far from desirable. Specifically because the TextDialog essentially emulates the titlebar of other windows. So, after this change, window.font.effect still controls the text in the editbox, but the titlebar area is themed as the titlebars of other windows. Text justification of titlebar and border width, is now respected in TextDialog. Also, previously the edit box was sized in an odd way; one which left part of the window actually undrawn (so you'd get artifacts from whatever happened to be on the screen in that position when it opened); this has been addressed. TextDialogs, rather than going to the center of the entire desktop, now center on the _current head_, which prevents the awful positioning where half of the window is on one screen and half is on another. Lastly, when hovering your mouse over the iconbar button for a window with a title that's too wide to fit on the button, a tooltip is displayed. This tooltip themes itself to match the button, however it wasn't using the theme properly (similarly to how TextDialog was)... and as such, also wasn't using the proper font effects. This has been addressed just as it was for the TextDialog.
2011-05-10Make SignalTracker always disconnect itself from SignalsPavel Labath1-4/+3
previously, the tracker disconnected itself only when the caller passed withTracker = true to the leave() function. However, the default value was for the parameter was false. Non disconnecting from signal when stopping tracking creates very dangerous situation because the signal still holds a pointer to the tracker. This resulted in a segfault when exiting fluxbox, because the tracker (FluxboxWindow) got destroyed before the signal (BScreen::focusedWindowSig), and the signal was using an invalid pointer when it tried to disconnect itself from the tracker. Instead of setting withTracker to true by default or changing all invocations of leave(), I decided to make the tracker disconnect itself unconditionally because I could not find a use case for the opposite behaviour. PS: This message is in fact longer than the actual commit.
2011-05-10Remove all trace of Observers and SubjectsPavel Labath15-359/+2
this marks the completion of the transition to FbTk::Signal
2011-05-10Convert ToolbarItem::resizeSig to FbTk::SignalPavel Labath6-19/+11
2011-05-10Convert Screen::reconfigureSig to FbTk::SignalPavel Labath5-29/+10
2011-05-10Convert Focusable::attentionSig to FbTk::SignalPavel Labath4-47/+10
2011-05-10Convert FbWinFrame::frameExtentSig to FbTk::SignalPavel Labath4-23/+13
Also, I spotted a potential bug in the code. I marked the place with XXX. Someone should take a look at that.
2011-05-10Convert FluxboxWindow::hintSig to FbTk::SignalPavel Labath2-6/+3
2011-05-10Convert FluxboxWindow::layerSig to FbTk::SignalPavel Labath6-86/+34
2011-05-10Convert FluxboxWindow::stateSig to FbTk::SignalPavel Labath8-59/+56
2011-05-10Remove Observers from testSignal.ccPavel Labath1-23/+0
2011-05-10Convert FluxboxWindow::workspaceSig to FbTk::SignalPavel Labath6-27/+40
2011-05-10Convert Focusable::orderSig,addSig,removeSig,resetSig to FbTk::SignalPavel Labath4-79/+72
2011-05-10Added FbTk::MemFunBind - a functor which binds all arguments of a functionPavel Labath1-0/+94
2011-05-10Make FbTk::MemFun[12] inherit from std::unary/binary_functionPavel Labath1-2/+3
this way, they can be used as inputs to std::bind1st and friends
2011-05-10Make FbTk::MemFun[0-3] use their ResultType parameterPavel Labath1-33/+33
previously they declared the parameter, but ignored the return value of the member function. I've changed it so they pass the return value, if it is not void. MemFunSelectArg didn't have the ReturnType template parameter, so I added it for consistency. Since I was already editing the, I made all the operator()s const.
2011-05-10Convert Focusable::dieSig to FbTk::SignalPavel Labath12-102/+77
2011-05-10Last round of simplification of Signal/Slot classesPavel Labath18-139/+103
- merged all the common stuff from 0,1,2,3 argument versions into one common base class - removed ReturnType template parameter as it was instantiated with "void" everywhere and the current ignores the return value of the callbacks anyway
2011-05-10Don't crash when a slot is deregistered in the middle of signal processingPavel Labath1-15/+46
this was possible (and used) with FbTk::Subject, but the implemetation of FbTk::Signal didn't support it, which made it impossible to continue with conversion.
2011-05-10Simplify Slot.hhPavel Labath2-254/+70
Replace CallbackHolder, FunctorHolder and SlotHolder with a (smaller) set of polymorphic classes. SignalHolder now stores a (smart) pointer to the class.
2011-05-10Make RefCount<> more sensiblePavel Labath12-23/+27
the previous version of operator*() made no sense. E.g., it violated the invariant (*ptr).foo <=> ptr->foo. The dereferencing operator now returns a reference to the pointed-to object, rather than a pointer to it. I also added a bool conversion operator, which can be used in testing the NULL-ness of the pointer. Anyone wondering if that could be done in a simpler way is encouraged to read <http://www.artima.com/cppsource/safebool.html>. And, finally, I removed the mutable flag from the m_data member, since it does not need it.
2011-05-10Remove the Observer dependency from FbTk::MenuPavel Labath4-15/+8
2011-05-10Convert FbTk::Theme::reconfigSig and friends to the new Signal systemPavel Labath34-115/+92
I removed the const versions of reconfigSig() in the process since FbTk::Signal has no const methods anyway.
2011-05-10Simplify FbTk::Signal template classes a bitPavel Labath1-64/+30
basically, i just got rid of Signal[0-3] classes and moved their contents to the appropriate specialization of FbTk::Signal also, this fixes the no matching function for call to 'MemFunIgnoreArgs(FbTk::Signal<void, FbTk::SigImpl::EmptyArg, FbTk::SigImpl::EmptyArg, FbTk::SigImpl::EmptyArg>&, void (FbTk::SigImpl::Signal0<void>::*)())' error i had in the following commit.
2011-05-09Fix make install failure with some autotools versionsPavel Labath1-3/+3
apparently, some versions of autotools don't know about $(builddir) variable. I replaced it with ".".
2011-05-08Can check CARDINAL properties in CLIENT PATTERNSnacitar sevaht10-63/+69
Introduces a new member function, FbWindow::cardinalProperty() This change also changes other code that previously used FbWindow::property() to do the same thing as the new function; this reduces code duplication. There are still some bits of code (Ewmh.cc, extractNetWmIcon()) that use FbWindow::property() to retrieve XA_CARDINAL values, but as the new method is designed for getting a _single_ property, and that code uses FbWindow::property() to retrieve the number of values present, and then grab all of them; it's a different use case. I opted to not try to make cardinalProperty() into some monolithic all-purpose cardinal method; FbWindow::property() works just fine for that. This change also adds an optional (default=NULL) boolean to FbWindow::textProperty and friends that allows the caller to determine whether or not a value was actually retrieved. This was necessary for integrating FbWindow::cardinalProperty with the codebase, and it seemed to fit with FbWindow::textProperty as well. Prior to this change, if you got a return value of "", you wouldn't know if you successfully retrieved the value which happened to be blank, or if you failed to retrieve the value. Now, you can pass the address of a boolean if you so choose in order to differentiate these situations; the same applies to the new FbWindow::cardinalProperty().
2011-05-08fluxbox-remote now properly returns exit statusnacitar sevaht1-5/+20
The previous check relied upon the (undocumented) return value of XChangeProperty to determine the exit status; at least, on my gentoo system, the function seems to return 1 even when it fails to change the property due to contrived, and invalid, parameters. However, setting an error handler allows proper detection of this case. So, now the return status properly indicates whether or not the property was changed (but not whether fluxbox liked the command!).
2011-05-07Include src/tests in the distribution tarballPavel Labath2-1/+21
and add a configure option for building them (default: off). This patch fixes an error when configuring the tarball, where configure complained it cannot find src/tests/Makefile.in.