fix infinite loop caused by deiconify command

2 files changed, 6 insertions, 3 deletions

diff --git a/src/FbCommands.cc b/src/FbCommands.cc
index 060f4d3..afa7984 100644
--- a/src/FbCommands.cc
+++ b/src/FbCommands.cc
@@ -394,8 +394,11 @@ void DeiconifyCmd::execute() {
     if (screen == 0)
         return;
 
-    BScreen::Icons::reverse_iterator it= screen->iconList().rbegin();
-    BScreen::Icons::reverse_iterator itend= screen->iconList().rend();
+    // we need to make a copy of the list of icons, or else our iterator can
+    // become invalid
+    BScreen::Icons icon_list = screen->iconList();
+    BScreen::Icons::iterator it = icon_list.begin();
+    BScreen::Icons::iterator itend= icon_list.end();
     unsigned int workspace_num= screen->currentWorkspaceID();
     unsigned int old_workspace_num;
 
diff --git a/src/Window.cc b/src/Window.cc
index 066d962..24fc8df 100644
--- a/src/Window.cc
+++ b/src/Window.cc
@@ -458,7 +458,7 @@ void FluxboxWindow::init() {
 
     restoreAttributes();
 
-    if (m_workspace_number < 0 || m_workspace_number >= screen().numberOfWorkspaces())
+    if (m_workspace_number >= screen().numberOfWorkspaces())
         m_workspace_number = screen().currentWorkspaceID();
 
     bool place_window = (m_old_pos_x == static_cast<signed>(m_screen.width()));