aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPavel Labath <pavelo@centrum.sk>2011-06-20 20:16:30 (GMT)
committerPavel Labath <pavelo@centrum.sk>2011-11-01 09:57:19 (GMT)
commit251a4c9ac62050e912fd861c4443ebe83948e22d (patch)
tree803926d40b5d5eb3980a6879c179e54def69cbb4
parentd4ff16c0e739663a0fec8b471d83e7004189fb29 (diff)
downloadfluxbox_paul-251a4c9ac62050e912fd861c4443ebe83948e22d.zip
fluxbox_paul-251a4c9ac62050e912fd861c4443ebe83948e22d.tar.bz2
Convert slitlist from a separate file to a regular lua resource
-rw-r--r--src/Screen.cc3
-rw-r--r--src/Slit.cc133
-rw-r--r--src/Slit.hh27
-rw-r--r--src/fluxbox.cc8
-rw-r--r--src/fluxbox.hh3
5 files changed, 96 insertions, 78 deletions
diff --git a/src/Screen.cc b/src/Screen.cc
index 77b7ca3..8ce0528 100644
--- a/src/Screen.cc
+++ b/src/Screen.cc
@@ -455,8 +455,7 @@ BScreen::BScreen(FbTk::ResourceManager_base &rm,
455 changeWorkspaceID(first_desktop); 455 changeWorkspaceID(first_desktop);
456 456
457#ifdef SLIT 457#ifdef SLIT
458 m_slit.reset(new Slit(*this, *layerManager().getLayer(ResourceLayer::DESKTOP), 458 m_slit.reset(new Slit(*this, *layerManager().getLayer(ResourceLayer::DESKTOP)));
459 fluxbox->getSlitlistFilename().c_str()));
460#endif // SLIT 459#endif // SLIT
461 460
462 XFlush(disp); 461 XFlush(disp);
diff --git a/src/Slit.cc b/src/Slit.cc
index d5d2dde..2e32f27 100644
--- a/src/Slit.cc
+++ b/src/Slit.cc
@@ -164,7 +164,67 @@ private:
164unsigned int Slit::s_eventmask = SubstructureRedirectMask | ButtonPressMask | 164unsigned int Slit::s_eventmask = SubstructureRedirectMask | ButtonPressMask |
165 EnterWindowMask | LeaveWindowMask | ExposureMask; 165 EnterWindowMask | LeaveWindowMask | ExposureMask;
166 166
167Slit::Slit(BScreen &scr, FbTk::Layer &layer, const char *filename) 167void Slit::SlitClientsRes::setFromLua(lua::state &l) {
168 lua::stack_sentry s(l, -1);
169 l.checkstack(1);
170
171 // to avoid modifying the master copy until we are sure the new list is ok
172 SlitClients copy(*this);
173 // this will be the new list once we are done
174 SlitClients t;
175
176 if(l.type(-1) != lua::TTABLE) {
177 std::cerr << "Cannot convert to a client list from lua type "
178 << l.type_name(l.type(-1)) << std::endl;
179 return;
180 }
181 for(size_t i = 1; l.rawgeti(-1, i), !l.isnil(-1); l.pop(), ++i) {
182 if(l.type(-1) != lua::TSTRING && l.type(-1) != lua::TNUMBER) {
183 std::cerr << "Cannot convert to a client name from lua type "
184 << l.type_name(l.type(-1)) << std::endl;
185 continue;
186 }
187 const std::string &name = l.tostring(-1);
188 // look for a matching window
189 bool found = false;
190 for(SlitClients::iterator j = copy.begin(); j != copy.end(); ++j) {
191 if((*j)->matchName().logical() == name) {
192 t.push_back(*j);
193 copy.erase(j);
194 found = true;
195 break;
196 }
197 }
198 if(!found) {
199 // no matching window, create a placeholder
200 t.push_back( new SlitClient(name.c_str()) );
201 }
202 } l.pop();
203
204 // move remaining non-placeholder clients to the new list
205 while(!copy.empty()) {
206 if(copy.front()->window() != None)
207 t.push_back(copy.front());
208 copy.pop_front();
209 }
210 SlitClients::operator=(t);
211
212 l.pop();
213}
214
215void Slit::SlitClientsRes::pushToLua(lua::state &l) const {
216 l.checkstack(2);
217 l.createtable(size());
218 lua::stack_sentry s(l);
219
220 int j = 1;
221 for(const_iterator i = begin(); i != end(); ++i) {
222 l.pushstring((*i)->matchName().logical());
223 l.rawseti(-2, j++);
224 }
225}
226
227Slit::Slit(BScreen &scr, FbTk::Layer &layer)
168 : m_hidden(false), m_visible(false), 228 : m_hidden(false), m_visible(false),
169 m_screen(scr), 229 m_screen(scr),
170 m_clientlist_menu(scr.menuTheme(), 230 m_clientlist_menu(scr.menuTheme(),
@@ -188,7 +248,7 @@ Slit::Slit(BScreen &scr, FbTk::Layer &layer, const char *filename)
188 m_slit_theme(new SlitTheme(scr.rootWindow().screenNumber())), 248 m_slit_theme(new SlitTheme(scr.rootWindow().screenNumber())),
189 m_strut(0), 249 m_strut(0),
190 // resources 250 // resources
191 // lock in first resource 251 m_client_list(scr.resourceManager(), scr.name() + ".slit.clientList"),
192 m_rc_kde_dockapp(scr.resourceManager(), true, scr.name() + ".slit.acceptKdeDockapps"), 252 m_rc_kde_dockapp(scr.resourceManager(), true, scr.name() + ".slit.acceptKdeDockapps"),
193 m_rc_auto_hide(scr.resourceManager(), false, scr.name() + ".slit.autoHide"), 253 m_rc_auto_hide(scr.resourceManager(), false, scr.name() + ".slit.autoHide"),
194 // TODO: this resource name must change 254 // TODO: this resource name must change
@@ -243,11 +303,6 @@ Slit::Slit(BScreen &scr, FbTk::Layer &layer, const char *filename)
243 303
244 moveToLayer(static_cast<int>(*m_rc_layernum)); 304 moveToLayer(static_cast<int>(*m_rc_layernum));
245 305
246
247
248 // Get client list for sorting purposes
249 loadClientList(filename);
250
251 setupMenu(); 306 setupMenu();
252} 307}
253 308
@@ -800,7 +855,6 @@ void Slit::reposition() {
800 855
801 856
802void Slit::shutdown() { 857void Slit::shutdown() {
803 saveClientList();
804 while (!m_client_list.empty()) 858 while (!m_client_list.empty())
805 removeClient(m_client_list.front(), true, true); 859 removeClient(m_client_list.front(), true, true);
806} 860}
@@ -824,6 +878,8 @@ void Slit::clientUp(SlitClient* client) {
824 break; 878 break;
825 } 879 }
826 } 880 }
881
882 saveClientList();
827} 883}
828 884
829void Slit::clientDown(SlitClient* client) { 885void Slit::clientDown(SlitClient* client) {
@@ -845,6 +901,8 @@ void Slit::clientDown(SlitClient* client) {
845 break; 901 break;
846 } 902 }
847 } 903 }
904
905 saveClientList();
848} 906}
849 907
850void Slit::cycleClientsUp() { 908void Slit::cycleClientsUp() {
@@ -857,6 +915,8 @@ void Slit::cycleClientsUp() {
857 m_client_list.erase(it); 915 m_client_list.erase(it);
858 m_client_list.push_back(client); 916 m_client_list.push_back(client);
859 reconfigure(); 917 reconfigure();
918
919 saveClientList();
860} 920}
861 921
862void Slit::cycleClientsDown() { 922void Slit::cycleClientsDown() {
@@ -868,6 +928,8 @@ void Slit::cycleClientsDown() {
868 m_client_list.remove(client); 928 m_client_list.remove(client);
869 m_client_list.push_front(client); 929 m_client_list.push_front(client);
870 reconfigure(); 930 reconfigure();
931
932 saveClientList();
871} 933}
872 934
873void Slit::handleEvent(XEvent &event) { 935void Slit::handleEvent(XEvent &event) {
@@ -998,40 +1060,6 @@ void Slit::toggleHidden() {
998 frame.window.move(frame.x, frame.y); 1060 frame.window.move(frame.x, frame.y);
999} 1061}
1000 1062
1001void Slit::loadClientList(const char *filename) {
1002 if (filename == 0 || filename[0] == '\0')
1003 return;
1004
1005 // save filename so we can save client list later
1006 m_filename = filename;
1007 string real_filename= FbTk::StringUtil::expandFilename(filename);
1008
1009 struct stat buf;
1010 if (stat(real_filename.c_str(), &buf) == 0) {
1011 ifstream file(real_filename.c_str());
1012 string name;
1013 while (! file.eof()) {
1014 name = "";
1015 getline(file, name); // get the entire line
1016 if (name.empty())
1017 continue;
1018
1019 // remove whitespaces from start and end
1020 FbTk::StringUtil::removeFirstWhitespace(name);
1021
1022 // the cleaned string could still be a comment, or blank
1023 if ( name.empty() || name[0] == '#' || name[0] == '!' )
1024 continue;
1025
1026 // trailing whitespace won't affect the above test
1027 FbTk::StringUtil::removeTrailingWhitespace(name);
1028
1029 SlitClient *client = new SlitClient(name.c_str());
1030 m_client_list.push_back(client);
1031 }
1032 }
1033}
1034
1035void Slit::updateClientmenu() { 1063void Slit::updateClientmenu() {
1036 if (screen().isShuttingdown()) 1064 if (screen().isShuttingdown())
1037 return; 1065 return;
@@ -1055,30 +1083,11 @@ void Slit::updateClientmenu() {
1055 m_clientlist_menu.insert(new SlitClientMenuItem(*this, *(*it), reconfig)); 1083 m_clientlist_menu.insert(new SlitClientMenuItem(*this, *(*it), reconfig));
1056 } 1084 }
1057 1085
1058 m_clientlist_menu.insert(new FbTk::MenuSeparator());
1059 FbTk::RefCount<FbTk::Command<void> > savecmd(new FbTk::SimpleCommand<Slit>(*this, &Slit::saveClientList));
1060 m_clientlist_menu.insert(_FB_XTEXT(Slit,
1061 SaveSlitList,
1062 "Save SlitList", "Saves the current order in the slit"),
1063 savecmd);
1064
1065 m_clientlist_menu.updateMenu(); 1086 m_clientlist_menu.updateMenu();
1066} 1087}
1067 1088
1068void Slit::saveClientList() { 1089void Slit::saveClientList() {
1069 1090 Fluxbox::instance()->save_rc();
1070 ofstream file(FbTk::StringUtil::expandFilename(m_filename).c_str());
1071 SlitClients::iterator it = m_client_list.begin();
1072 SlitClients::iterator it_end = m_client_list.end();
1073 string prevName;
1074 string name;
1075 for (; it != it_end; ++it) {
1076 name = (*it)->matchName().logical();
1077 if (name != prevName)
1078 file << name.c_str() << endl;
1079
1080 prevName = name;
1081 }
1082} 1091}
1083 1092
1084void Slit::setupMenu() { 1093void Slit::setupMenu() {
diff --git a/src/Slit.hh b/src/Slit.hh
index 5c69a8c..9384ad6 100644
--- a/src/Slit.hh
+++ b/src/Slit.hh
@@ -68,7 +68,7 @@ public:
68 RIGHTBOTTOM, RIGHTCENTER, RIGHTTOP 68 RIGHTBOTTOM, RIGHTCENTER, RIGHTTOP
69 }; 69 };
70 70
71 Slit(BScreen &screen, FbTk::Layer &layer, const char *filename = 0); 71 Slit(BScreen &screen, FbTk::Layer &layer);
72 virtual ~Slit(); 72 virtual ~Slit();
73 73
74 void show() { frame.window.show(); m_visible = true; } 74 void show() { frame.window.show(); m_visible = true; }
@@ -137,7 +137,6 @@ private:
137 void setupMenu(); 137 void setupMenu();
138 138
139 void removeClient(SlitClient *client, bool remap, bool destroy); 139 void removeClient(SlitClient *client, bool remap, bool destroy);
140 void loadClientList(const char *filename);
141 void updateClientmenu(); 140 void updateClientmenu();
142 void clearStrut(); 141 void clearStrut();
143 void updateStrut(); 142 void updateStrut();
@@ -148,13 +147,11 @@ private:
148 BScreen &m_screen; 147 BScreen &m_screen;
149 FbTk::Timer m_timer; 148 FbTk::Timer m_timer;
150 149
151 SlitClients m_client_list;
152 std::auto_ptr<LayerMenu> m_layermenu; 150 std::auto_ptr<LayerMenu> m_layermenu;
153 FbMenu m_clientlist_menu, m_slitmenu; 151 FbMenu m_clientlist_menu, m_slitmenu;
154#ifdef XINERAMA 152#ifdef XINERAMA
155 XineramaHeadMenu<Slit> *m_xineramaheadmenu; 153 XineramaHeadMenu<Slit> *m_xineramaheadmenu;
156#endif // XINERAMA 154#endif // XINERAMA
157 std::string m_filename;
158 155
159 struct frame { 156 struct frame {
160 frame(const FbTk::FbWindow &parent): 157 frame(const FbTk::FbWindow &parent):
@@ -179,6 +176,28 @@ private:
179 static unsigned int s_eventmask; 176 static unsigned int s_eventmask;
180 Strut *m_strut; 177 Strut *m_strut;
181 178
179 class SlitClientsRes: public FbTk::Resource_base, public SlitClients {
180 public:
181 SlitClientsRes(FbTk::ResourceManager_base &rm, const std::string &name)
182 : FbTk::Resource_base(name, name), m_rm(rm) {
183 m_rm.addResource(*this);
184 }
185
186 ~SlitClientsRes() {
187 m_rm.removeResource(*this);
188 }
189
190 virtual void setDefaultValue() {}
191 virtual void setFromString(const char *) { assert(0); }
192 virtual std::string getString() const { assert(0); }
193 virtual void setFromLua(lua::state &l);
194 virtual void pushToLua(lua::state &l) const;
195
196 private:
197 FbTk::ResourceManager_base &m_rm;
198 };
199
200 SlitClientsRes m_client_list;
182 FbTk::BoolResource m_rc_kde_dockapp, m_rc_auto_hide, m_rc_maximize_over; 201 FbTk::BoolResource m_rc_kde_dockapp, m_rc_auto_hide, m_rc_maximize_over;
183 FbTk::Resource<Slit::Placement, FbTk::EnumTraits<Slit::Placement> > m_rc_placement; 202 FbTk::Resource<Slit::Placement, FbTk::EnumTraits<Slit::Placement> > m_rc_placement;
184 FbTk::IntResource m_rc_alpha, m_rc_on_head; 203 FbTk::IntResource m_rc_alpha, m_rc_on_head;
diff --git a/src/fluxbox.cc b/src/fluxbox.cc
index 156febf..07d5436 100644
--- a/src/fluxbox.cc
+++ b/src/fluxbox.cc
@@ -243,7 +243,6 @@ Fluxbox::Fluxbox(int argc, char **argv,
243 m_rc_styleoverlayfile(m_resourcemanager, m_RC_PATH + "/overlay", "styleOverlay", "StyleOverlay"), 243 m_rc_styleoverlayfile(m_resourcemanager, m_RC_PATH + "/overlay", "styleOverlay", "StyleOverlay"),
244 m_rc_menufile(m_resourcemanager, m_RC_PATH + "/menu", "menuFile", "MenuFile"), 244 m_rc_menufile(m_resourcemanager, m_RC_PATH + "/menu", "menuFile", "MenuFile"),
245 m_rc_keyfile(m_resourcemanager, m_RC_PATH + "/keys", "keyFile", "KeyFile"), 245 m_rc_keyfile(m_resourcemanager, m_RC_PATH + "/keys", "keyFile", "KeyFile"),
246 m_rc_slitlistfile(m_resourcemanager, m_RC_PATH + "/slitlist", "slitlistFile", "SlitlistFile"),
247 m_rc_appsfile(m_resourcemanager, m_RC_PATH + "/apps", "appsFile", "AppsFile"), 246 m_rc_appsfile(m_resourcemanager, m_RC_PATH + "/apps", "appsFile", "AppsFile"),
248 m_rc_tabs_attach_area(m_resourcemanager, ATTACH_AREA_WINDOW, "tabsAttachArea", "TabsAttachArea"), 247 m_rc_tabs_attach_area(m_resourcemanager, ATTACH_AREA_WINDOW, "tabsAttachArea", "TabsAttachArea"),
249 m_rc_cache_life(m_resourcemanager, 5, "cacheLife", "CacheLife"), 248 m_rc_cache_life(m_resourcemanager, 5, "cacheLife", "CacheLife"),
@@ -1174,13 +1173,6 @@ void Fluxbox::load_rc() {
1174 1173
1175 FbTk::Transparent::usePseudoTransparent(*m_rc_pseudotrans); 1174 FbTk::Transparent::usePseudoTransparent(*m_rc_pseudotrans);
1176 1175
1177 if (!m_rc_slitlistfile->empty()) {
1178 *m_rc_slitlistfile = StringUtil::expandFilename(*m_rc_slitlistfile);
1179 } else {
1180 string filename = getDefaultDataFilename("slitlist");
1181 m_rc_slitlistfile.setFromString(filename.c_str());
1182 }
1183
1184 *m_rc_colors_per_channel = FbTk::Util::clamp(*m_rc_colors_per_channel, 2, 6); 1176 *m_rc_colors_per_channel = FbTk::Util::clamp(*m_rc_colors_per_channel, 2, 6);
1185 1177
1186 if (m_rc_stylefile->empty()) 1178 if (m_rc_stylefile->empty())
diff --git a/src/fluxbox.hh b/src/fluxbox.hh
index 47a8187..e7d2d68 100644
--- a/src/fluxbox.hh
+++ b/src/fluxbox.hh
@@ -121,7 +121,6 @@ public:
121 const std::string &getStyleOverlayFilename() const { return *m_rc_styleoverlayfile; } 121 const std::string &getStyleOverlayFilename() const { return *m_rc_styleoverlayfile; }
122 122
123 const std::string &getMenuFilename() const { return *m_rc_menufile; } 123 const std::string &getMenuFilename() const { return *m_rc_menufile; }
124 const std::string &getSlitlistFilename() const { return *m_rc_slitlistfile; }
125 const std::string &getAppsFilename() const { return *m_rc_appsfile; } 124 const std::string &getAppsFilename() const { return *m_rc_appsfile; }
126 const std::string &getKeysFilename() const { return *m_rc_keyfile; } 125 const std::string &getKeysFilename() const { return *m_rc_keyfile; }
127 int colorsPerChannel() const { return *m_rc_colors_per_channel; } 126 int colorsPerChannel() const { return *m_rc_colors_per_channel; }
@@ -242,7 +241,7 @@ private:
242 m_rc_tabs_padding; 241 m_rc_tabs_padding;
243 FbTk::StringResource m_rc_stylefile, 242 FbTk::StringResource m_rc_stylefile,
244 m_rc_styleoverlayfile, 243 m_rc_styleoverlayfile,
245 m_rc_menufile, m_rc_keyfile, m_rc_slitlistfile, 244 m_rc_menufile, m_rc_keyfile,
246 m_rc_appsfile; 245 m_rc_appsfile;
247 246
248 247