Age | Commit message (Collapse) | Author | Files | Lines |
|
Fix fbrun completion search for last directory in PATH
|
|
|
|
|
|
This follows the escaped chars in bash completion and allows to pass
filenames with spaces etc.
Using quotes would be another option but requires special handling of
"~" and, what's worse, either hand-correcting the cursor position (into
the quoted area) or more completion mumbo-jumbo to handle the quotes.
|
|
ie. w/o any / in the given path we'll get an irregular split point and
thus out of bounds array access
|
|
This allows to complete random things, useful along the -print flag but
also to limit the commands to those found my menumaker etc.
|
|
the default is 1024-1025, values are read from the FBRUN_HISTORY_SIZE
environment variable
NOTICE: the limit isn't hard, but will typically be n+1 and only n if
the new entry is already present in the last n entries
REQUEST: 202
|
|
|
|
- streamline code
- indicate completion by making use of selection
- fix buggy behavior (notably subsequent completions and FS path
following)
- support "~" in paths
- support chunk completion
(ie. "mp[layer] ~/vid[eos/favporn.mp4]" can be completed in both
tokens; buggy with paths including spaces in non-leafs)
REQUEST: 223
|
|
This commit fixes issues #72 (brought up + different solution by Mattias
Guns; I received a similar patch by 'Nable 80' via ML and discussed the
issue in #fluxbox with 'Nable 80'), patch #73 (Mattias Guns) and finally
patch #162 (Ulrich Eckhardt; this commit is heavily based upon Ulrich's
work).
The original code was overly complex. It tried to avoid writing
bytes to the disk at the expense of comprehensibility and as a result it
was buggy. I looked at both patches from Mattias and 'Nable 80' which address
the bug with skipping entries in the history-file (my fault: incorrect use
of outfile.ignore(1, '\n')): They provided a proper fix for the problem
but I decided to use Ulrich's code since it improves the whole code by making
it a lot simpler.
So, kudos to all of you.
|
|
Previous code add one additional entry on loading the history. This
commit is one part of the patch #162 (see [1] and [2]), written
by Ulrich Eckhardt <doomster@knuut.de>.
[1]: https://sourceforge.net/p/fluxbox/patches/162/
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=10;filename=fbrun-bug636632.patch;att=1;bug=636632
|
|
Do not try to be too smart which compilations need config.h, as most of
them will simply because of the config.h has information about system
capabilities.
|
|
|
|
Found with cppcheck.
|
|
|
|
a 'BidiString' holds both the logical content and the visual reordered
version of the content of a string. this helps to reduce the number of
calls to reorder the string before drawing it (as introduced in the patch
from Ken Bloom) and to be more consistent in menus and textboxes (drawing
cursors and underlining text).
|
|
|
|
|
|
|
|
|
|
|
|
on *bsd /bin/sh is not just a symlink to /bin/bash as on most linux's
but a real standalone shell. and it behaves differently from "bash -c"
behavior .. it doesnt exec the command given but waits till the command
finishes. as a result a lot of "rogue" a flying around. solution is now
( $SHELL or /bin/sh ) -c exec <cmd>
|
|
|
|
|
|
+ thanks Jonas Koelker, sf.net rfe #1333003, patch #1475578
|
|
|
|
|
|
|
|
|
|
if the xkb-extension is enabled and the user switches between his/her
keyboardlayouts fluxbox's keybhandling doesn't work well anymore because
xkeyevent.state contains also xkb-related flags and thus we have to handle
that with caution.
KeyUtils now contain 'isolateModifierMask()' to really work only on the
modifiers. why not as part of cleanMods() ? because the XLookupString return
false results, eg TextBox's would only print chars from the first
keyboardlayout.
|
|
|
|
execl needs a terminating NULL at the end, a '0' would be
converted to "int 0" on 64bit-systems
|
|
|
|
file and directory - helproutines.
* created the FileUtil-namespace which contains file-related functions, moved
those functions out of Directory - code
* changes to the rest of the files to follow those changes
|
|
|
|
think)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|