aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2012-04-10Bugfix: Don't draw the interlace lines 1px too farMathias Gumz1-1/+1
2012-04-06Allow percentage values for some Window commandsLajos Koszti12-88/+386
2012-01-04FocusableList.cc,.hh: Pass string arguments by const reference.Ryan Pavlik2-4/+4
Found by cppcheck
2012-01-04FbTk/XrmDatabaseHelper.hh: operator== can be const.Ryan Pavlik1-1/+1
Found with cppcheck.
2012-01-04Check .empty() instead of .size() == 0Ryan Pavlik1-2/+2
Found with cppcheck.
2012-01-04Pre-increment non-primitive types.Ryan Pavlik16-36/+36
Found with cppcheck: "Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code."
2012-01-04Exceptions should be caught by reference.Ryan Pavlik4-4/+4
Found using cppcheck.
2012-01-04Add mwm _MOTIF_WM_INFO atom to advertise mwm hints capabilityDaniel Diaz2-0/+2
Applications like urxvt look for the _MOTIF_WM_INFO atom in order to know if the window manager implements mwm hints. If this atom is not found, then urxvt sets override_redirect when started with the borderless option and falls out of the control of Fluxbox.
2012-01-04No need to check if a pointer is null before de-allocating it.Paul Tagliamonte1-2/+1
5.3.5/2 of the C++ standard: "In either alternative, if the value of the operand of delete is the null pointer the operation has no effect."
2011-10-31src/Makefile.am,FbTk/StringUtil.cc: Search relative to the executable.Ryan Pavlik2-7/+78
On Windows, prepend /DUMMYPREFIX to default paths, and replace it at runtime with the prefix relative to the exe directory.
2011-10-31FbTk/StringUtil.cc: Don't return mid-routine.Ryan Pavlik1-2/+3
Prep for Windows dummy prefix code.
2011-10-31main.cc,FbTk/StringUtil.cc: On windows, use USERPROFILE instead of HOMERyan Pavlik2-1/+8
2011-10-31FbTk/FbString.cc,Font.cc: Windows doesn't have nl_langinfoRyan Pavlik2-4/+4
2011-10-31FbCommands.cc: Implement ExecuteCmd for WindowsRyan Pavlik1-5/+17
2011-10-31main.cc: Add a wrapper for two-argument mkdir on WindowsRyan Pavlik1-0/+8
2011-10-31fluxbox.cc: ifdef the signals windows doesn't have.Ryan Pavlik1-1/+8
2011-10-31FbTk/Timer.cc: Check HAVE_SYS_SELECT_H, add alternate for windowsRyan Pavlik1-0/+2
2011-10-31Merge branches 'fix-out-of-range-memory', 'obey-configure' and ↵Ryan Pavlik9-20/+48
'other-improvements' into windows-mingw
2011-10-31FbTk/App.cc: make startup failure easier to diagnoseRyan Pavlik1-2/+7
2011-10-31main.cc: Use expandFilename for default pathsRyan Pavlik1-6/+7
2011-10-31src/Makefile.am: Add warning to defaults.cc as wellRyan Pavlik1-0/+1
2011-10-31main.cc: Check getenv output better.Ryan Pavlik1-2/+2
Windows returns pointers to empty strings for non-existent env vars.
2011-10-31FbTk/FileUtil.cc: Use only file masks defined.Ryan Pavlik1-3/+8
Needed for mingw-cross-env
2011-10-31FbTk/SignalHandler.cc: Use HAVE_SIGACTION, with signal() fallbackRyan Pavlik1-1/+7
This fixes platforms without sigaction, like Windows.
2011-10-31FbTk/Timer.cc: Check HAVE_SYS_SELECT_HRyan Pavlik1-1/+3
2011-10-31FbTk/StringUtil.cc: Fix out-of-range memory access.Ryan Pavlik1-1/+1
if pos is not npos, it will always be less than filename.size(). However, the access later is only safe if there is a character after pos, which would require pos + 1 to be less than filename.size.
2011-10-31RootTheme.cc: Obey HAVE_SYS_WAIT_HRyan Pavlik1-0/+3
2011-10-31main.cc: Only sync() if we can.Ryan Pavlik1-1/+4
2011-10-31fluxbox.cc: check HAVE_SYS_WAIT_HRyan Pavlik1-0/+2
2011-10-31FbTk/I18n.cc: Constructor should also check defined(NLS)Ryan Pavlik1-4/+4
2011-10-23bugfix: use the imlib cache for every imlib context usedMathias Gumz1-5/+5
calling imlib_set_cache_size() before a context is created by fluxbox creates an 'unknown' context. that one is never freed at shutdown.
2011-10-23clean up imlib2 loaders at shutdownMathias Gumz1-0/+2
2011-10-23clean up resources on shutdownMathias Gumz1-10/+12
2011-10-23small code simplificationMathias Gumz1-73/+68
2011-10-22Bugfix: clean up static resources correctlyMathias Gumz2-13/+11
93924af160ea303c94a2576b0e57a04e94c9228c might corrupt memory with gcc-4.6.1 when finishing fluxbox (clicking 'exit', sending it a SIGINT). Allthough the order, in which static / global objects are initialized is undefined (at least between separate compilation units), the order in which they are destroyed is well defined: in reverse order of initialization. this means, that if 'ScreenImlibContextContainer contexts' (of ImageImlib2.cc) gets initialized AFTER 'ImageImlib2 imlib2_loader' of Image.cc, it gets destroyed before imlib2_loader. When that happens, ~ImageImlib2() works on a destroyed object. (That lead to '* glibc detected * fluxbox: corrupted double-linked list: 0x0000000000dd2710 ***' later on in 'iconv_close')
2011-10-21refactored MenuCreatorMathias Gumz2-102/+85
make public only what needs to be public
2011-10-20Added support for ARGB visual, patch #3284774Gediminas Liktaras7-32/+90
fluxbox now properly displays windows that require ARGB visuals when an external compositor is running. This was done by creating the container window with the correct visual and colormap when needed. Closes #2874629
2011-10-17removed obsolete handler for the gnome-window manager hintsMathias Gumz5-585/+1
nowadays every app should use the extended window manager hints exclusively.
2011-09-14Fix compilation with intel's compilerPavel Labath1-4/+0
the deleted function was never used, otherwise it would generate an error with other compilers as well. icc noticed that it was nonsensical even when it wasn't used and complained.
2011-09-14Make sure FocusableList disconnects from signals when it is destroyedPavel Labath2-15/+11
2011-09-14Enable connecting to const SignalsPavel Labath1-17/+19
The idea is that connecting to a signal doesn't change it's state or the state of the object owning the signal (even though it needs to add the functor to the list for later reference). Emitting, on the other hand, is usually done as a result of a state change and therefore remains non-const. Additional benefit of this arrangement is that objects can export const references to signals to allow connecting, while keeping the ability to emit to themselves.
2011-09-14Add explicit ReturnType cast to operator() of FbTk::SlotsPavel Labath1-4/+5
without this it wasn't possible to construct a Slot returning void from functors returning some real value because the compiler would complain about "return statement with a value in a function returning void". Theoretically, this may produce some unexpected type conversions, because static_cast is slightly stronger than implicit cast, but I judge the risk to be negligable (the alternative would be to provide explicit specializations for slots returning void - too much typing)
2011-09-14Upgrade FbTk::Timer so it can take an arbitrary functor as a parameterPavel Labath2-2/+20
2011-09-14Rename Signal::connect function taking an already-constructed slot to ↵Pavel Labath1-7/+7
connectSlot I do this to avoid compiler ambiguity between the two versions of connect()
2011-09-14Add comparison operators to FbTk::RefCountPavel Labath1-0/+30
without them, gcc would compare them by converting them to bool first, which is not exactly what one would expect. Frankly, I'm surprised it even worked without this.
2011-09-14Use RefCount to store keybindingsPavel Labath2-58/+39
I'm doing this because I want to have access to keybindings from lua and for that I need more flexible ownership semantics.
2011-09-14Remove the assignment operator from a regular pointer to a RefCountPavel Labath5-11/+9
it is too easy too shoot yourself in the foot with it, other smart pointers also don't allow such assignments. If you do want to assign to a RefCount pointer, use reset(). ps: assignment between two RefCounts remains possible, of course.
2011-09-14Remove obsolete codePavel Labath1-8/+0
ps: it was already commented out, I'm just deleting it
2011-09-14add FbTk::makeRef function, for easier construction of RefCount pointersPavel Labath1-0/+20
2011-09-14FbTk::Timer accepts Slots instead of Commands as the former are more generalPavel Labath2-8/+8