aboutsummaryrefslogtreecommitdiff
path: root/src/Screen.cc
AgeCommit message (Collapse)AuthorFilesLines
2015-01-22Add -no-slit and -no-toolbar flagsMathias Gumz1-53/+56
Sometimes fluxbox is used as a component of a desktop environment ( e.g., the "Lumina Desktop"). It's easier and more stable for this kind of "users" to disable the toolbar or the slit alltogether. Why not configure these features out? Because then they would need 2 installations of fluxbox: One without the slit and the toolbar (and perhaps other components) and one with them. This implements feature request #314, at least partially. This commit also looks bigger than it actually is: I refactored and cleaned up classes Fluxbox and BScreen.
2015-01-22Fix removing windows from icon listMathias Gumz1-3/+3
std::remove_if() removes an item from a container and returns a past-the-end iterator ... which equals m_icon_list.end(). As a result the check if (erase_it != m_icon_list.end()) { iconList().erase(erase_it); iconListSig().emit(*this); } will never succeed and thus the iconListSig() will never be emitted.
2015-01-21Fix segfault on shutdownMathias Gumz1-44/+8
There was a problem deep within how the menus were connected and when and what gets deleted. It was clearly related to a menu which was kind of global. In order to better understand the code flow I eliminated the ExtraMenu code: it was used only to get the Remember-Menu into the Window-Menu. Instead of having a singleton of the Remember-Menu and fight against the shaky interconnections we just create a new one on demand and delete when the menu gets deleted. Looks like this fixes the problem. The menu code needs more love anyway. Closes #1118
2015-01-21Fix behavior for autorepeat keysMathias Gumz1-2/+7
This reverts 58e09b719077605efadac9b712acb8f5e752f732 after having regressions and bug reports in regards to autorepeated key events are not working anymore. So, the problem with the lost keypress after the workspace change is still open but at least the behavior for other folks is as it was. Since 58e09b7190 seems to be corelated to "auto repeat" keys it might indicate the problem which 58e09b7190 "fixed". We will see. Fixes #1115.
2015-01-21Minor cosmeticsMathias Gumz1-7/+6
2015-01-21Fix compile errors with clangMathias Gumz1-5/+1
2015-01-19Fix compile error: old g++ does not like c-like struct initializationMathias Gumz1-5/+4
2015-01-16Fix uninitialized variables; cosmeticsMathias Gumz1-17/+5
Note: I expect only modern compilers will hit the source of fluxbox. It seems futile to guard stdlib headers while demanding <algorithm> etc. This should trim down the noise in the source quite a bit.
2015-01-16Refactor: bundle xinerama-info together, simpler codeMathias Gumz1-49/+35
Part of this massive looking but simple rather simple change is a the way we check for active Xinerama: XineramaIsActive() was used before. The docs for XineramaQueryScreens() state that XineramaQueryScreens() returns NULL and sets number to 0 if Xinerama is not active. Sold.
2015-01-16Refactor: move some menu-creation functions to MenuCreatorMathias Gumz1-22/+4
Another patch to trim down the code that needs to be part of BScreen
2015-01-16Reduce number of allocations for menu creationMathias Gumz1-12/+15
Every time either the Slit menu or the Toolbar menu were added to the root menu, the whole root menu was (re)created from scratch. Now we create and remove only the menus needed. Side effect: the position of these menus is now at the end of the root menu and not somewhere in between. If users complaint, I' ll think about it.
2015-01-15Refactor: split out menu generation from BScreenMathias Gumz1-358/+9
Again, it's easier to read the code when the whole menu-generation is out of the way.
2015-01-15Refactor menu code: be more explicit and compactMathias Gumz1-27/+25
This commit is a preparation step for some menu cleanup ahead. To make it easier to understand which types of MenuItems are added where and when, I converted the overloaded FbTk::Menu::insert() functions into explicit ones (Menu::insertSubmenu(), Menu::insertItem(), etc. ). This makes it possible to just grep for 'insertSubmenu()'. Side effect this commit: it trims down the very verbose creation of menu items in regards to how the labels are created. Minor: FbTk::Menu::shown and FbTk::Menu::s_focused are moved out of the class.
2015-01-03Minor API change for OSDWindowMathias Gumz1-7/+6
OSDWindow::resize(const FbTk::BiDiString&) shadowed FbWindow::resize(x, y). To fix this I renamed the function to OSDWindow::resizeForText() to make the intention clear.
2014-09-29treat windows having WM_CLASS == "DockApp" like DockAppsMathias Gumz1-4/+9
this commit implements feature-request #317: "Add support for GTK dockapps.": "Back in 2010, WindowMaker implemented a system where windows with WM_CLASS res_class = DockApp would be treated as if they had initial_state = WithdrawnState, since GTK refuses to allow this."
2014-04-11merge Sami Kerola's new build-systemMathias Gumz1-19/+7
2013-08-02Fix lost keypresses after workspace change (#1067)Ed Martin1-6/+2
Do not Ungrab the keyboard for a KeyPress event, this causes us to lose the KeyRelease event which is needed to ungrab the keyboard after the event happened.
2013-05-26build-sys: use pkg-config to locate dependenciesSami Kerola1-10/+7
This commit alters XRANDR (X Resize And Rotate) extension dependency, which is expected to have at least version 1.4. Earlier old versions of xrandr were supported, at least to some extent.
2013-05-26build-sys: use AC_USE_SYSTEM_EXTENSIONSSami Kerola1-5/+0
The earlier _GNU_SOURCE definitions possibly did not take effect everywhere where it was intended.
2013-05-26build-sys: include config.h to all files using automakeSami Kerola1-4/+0
Do not try to be too smart which compilations need config.h, as most of them will simply because of the config.h has information about system capabilities.
2013-05-23minorMathias Gumz1-1/+1
2013-05-23fix head detection for adjacent heads of too different sizes and window ↵Peter Hercek1-11/+14
placement based on apps file * if you have e.g a 1920x1200 monitor and a small 800x600 monitor to the right of the bigger one and a small window at the right side of the big monitor (but still the whole window area at the big monitor) then the original head detection would claim the window is on the small monitor because (800/2+windowWidth/2 < 1920/2+windowWidth/2) is true for small windows; but that is obviously wrong, the window is entirely on the big monitor * these incorrect head detections did lead to incorrect window placements as they were required in the apps file
2013-01-31Adds 'ClientPatternTest' commandMathias Gumz1-28/+38
ClientPatterns might be tricky to get right. Instead of fiddling around in either the keys-file or the apps-file and restarting fluxbox to see if the changes had any effect / matched the right windows, 'ClientPatternTest' and the fluxbox-remote should make this easier: $> fluxbox-remote "clientpatterntest (title=.*vim*)" This causes fluxbox to store the list of matched windows in the _FLUXBOX_ACTION_RESULT property onto the rootwindow. This property might then be read by: $> xprop -root _FLUXBOX_ACTION_RESULT or $> fluxbox-remote result The format of the list is: win_id \t title_of_window \n win_id is '-1' when fluxbox wasn't able to parse the given ClientPattern. win_id is '0' when there are no windows matching the given ClientPattern.
2013-01-10Optional removal of SystemTray toolMathias Gumz1-1/+3
Added the option to remove the SystemTray tool completely from fluxbox.
2012-12-12Fix build regression: enable XRANDR support by defaultMathias Gumz1-11/+18
The changes made in b178bed60b5bd8b2c9ed0cbc67fd729ff3820589 used the wrong variable to set the default state of '--enable-randr' in configure.in, that is fixed now. I also removed '--enable-randr12': If support for the Xrandr-extension is available at compile time we set HAVE_RANDR; if there is also support for Xrandr-1.2 (or higher), we also set HAVE_RANDR1_2 automatically. Other changes: * cleaned out public interface of 'class Fluxbox' * added 'RANDR' to output of 'fluxbox -info'
2012-12-05Simplified 'configure' / build systemMathias Gumz1-10/+10
* reduced duplicated auto-code * renamed '--enable-newwmspec' to '--enable-ewmh' * don't compile 'Slit'-code when '--disable-slit' * use AS_IF() in configure.in * use AS_HELP_STRING() instead of obsolete AC_HELP_STRING in configure.in * removed redundant calls to 'imlib2-config' to fill in $IMLIB2_CFLAGS and $IMLIB2_LIBS, AC_PATH_GENERIC() does that out of the box already
2012-11-20Added option for focus revert to stay on current headHendrik Iben1-0/+11
2012-04-06Allow percentage values for some Window commandsLajos Koszti1-0/+49
2012-01-04Pre-increment non-primitive types.Ryan Pavlik1-2/+2
Found with cppcheck: "Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code."
2012-01-04Exceptions should be caught by reference.Ryan Pavlik1-1/+1
Found using cppcheck.
2011-09-14Remove obsolete codePavel Labath1-8/+0
ps: it was already commented out, I'm just deleting it
2011-09-14Fix a small bug in BScreen constructorPavel Labath1-1/+1
it was testing for FbWindow.property() == Success, where it should've tested for == true.
2011-05-10Convert Screen::reconfigureSig to FbTk::SignalPavel Labath1-3/+1
2011-05-10Convert FbTk::Theme::reconfigSig and friends to the new Signal systemPavel Labath1-5/+3
I removed the const versions of reconfigSig() in the process since FbTk::Signal has no const methods anyway.
2011-05-08Can check CARDINAL properties in CLIENT PATTERNSnacitar sevaht1-6/+5
Introduces a new member function, FbWindow::cardinalProperty() This change also changes other code that previously used FbWindow::property() to do the same thing as the new function; this reduces code duplication. There are still some bits of code (Ewmh.cc, extractNetWmIcon()) that use FbWindow::property() to retrieve XA_CARDINAL values, but as the new method is designed for getting a _single_ property, and that code uses FbWindow::property() to retrieve the number of values present, and then grab all of them; it's a different use case. I opted to not try to make cardinalProperty() into some monolithic all-purpose cardinal method; FbWindow::property() works just fine for that. This change also adds an optional (default=NULL) boolean to FbWindow::textProperty and friends that allows the caller to determine whether or not a value was actually retrieved. This was necessary for integrating FbWindow::cardinalProperty with the codebase, and it seemed to fit with FbWindow::textProperty as well. Prior to this change, if you got a return value of "", you wouldn't know if you successfully retrieved the value which happened to be blank, or if you failed to retrieve the value. Now, you can pass the address of a boolean if you so choose in order to differentiate these situations; the same applies to the new FbWindow::cardinalProperty().
2011-04-14bugfix: use 'unsigned long' to feed XChangeProperty, closes #3285968David Coppa1-1/+1
old code crashed on sparc64, pid_t seems to be 32bit on that platform.
2011-03-23compile fix: arguments must match declarationMathias Gumz1-4/+4
Sun CC++ 5.11 complaint on linking about missing symbols 'nextWorkspace()', 'prevWorkspace()' etc.
2011-03-23compile fix: sunCC 5.11 (sunstudio 12) compiles and links againMathias Gumz1-4/+4
biggest change: renaming of 'class Layer' to 'class ResourceLayer' in Layer.hh to handle complaints about 'ambiguous Layer: Layer or FbTk::Layer'. 'ResourceLayer' sounds crappy, but that was the best I could come up with right now.
2011-03-19delete config menu first at shutdownHenrik Kinnunen1-3/+11
2011-03-19bugfix: reposition windows only if they are invisibleMathias Gumz1-4/+19
changing the layout or the number of the attached monitors might lead to invisible windows. only those windows should be positioned to the closest monitor, if they are not visible already.
2011-03-19code deduplication: use RectangleUtil::insideBorder()Mathias Gumz1-4/+1
2011-03-19prepare BScreen::XineramaHeadInfo to be 'RectangleLike'Mathias Gumz1-9/+10
2011-02-24cache result of getWorkspace()Mathias Gumz1-2/+3
2011-02-23renamed FbTk::XLayer to FbTk::Layer and FbTk::XLayerItem to FbTk::LayerItemMathias Gumz1-2/+2
2011-01-15small refactoring of FbTk/Menu codeMathias Gumz1-1/+1
* removed useless struct _menu * code deduplication via renderMenuPixmap() * improved documentation: - 'sublevel' actually means 'column' - 'persub' means 'row_per_column'
2011-01-13compile fix: missing symbol (SystemTray::getNetSystemTray()) when configured ↵Mathias Gumz1-1/+4
--disable-toolbar
2010-09-18recovered lost change from 041d586972db4da170123f5468d7b11d4eda8ae5Mathias Gumz1-96/+65
got lost in d3eabeb805fdbd162c0743ed86a67e014e37c097 somehow
2010-09-17missing initializationsMathias Gumz1-0/+1
'valgrind' reported a lot of code branches based upon uninitialized variables. some are not identified yet.
2010-09-17moved commandline parsing to its own functionMathias Gumz1-66/+96
2010-09-17code simplification by reducing if-else hellMathias Gumz1-96/+66
a lot of the parsing-related and menu-building stuff is just plain stupid boiler plate code. putting the data into a const array separates the boiler plate data from the actual code.