aboutsummaryrefslogtreecommitdiff
path: root/src/FbTk
AgeCommit message (Collapse)AuthorFilesLines
2013-01-13improved code documentationMathias Gumz2-14/+3
2013-01-13Minor optimization of handling the timersMathias Gumz1-15/+15
2013-01-12Fix bug: handle the list of Timers not in-placeMathias Gumz1-14/+18
With commit 541c8c4 we switched from an (manually) ordered list to a std::set<> to handle the active timers. The code which checks for overdue timers now traverses and modifies the std::set<> in place. This might lead to an infinite loop. Examples of such bad behavior are "flickering of the tooltip" (bug #3590078) or crashes (bug #3600143) or just insanely high cpu load when autoraising windows or submenus. We now make a copy of the std::set<> traverse this instead of the original.
2013-01-02Compile fix: forgotten parentheses around valueMathias Gumz1-1/+1
2012-12-30replace XKeycodeToKeysym() with XkbKeycodeToKeysym()Sami Kerola1-2/+3
The XKeycodeToKeysym() is deprecated. References: http://comments.gmane.org/gmane.comp.misc.suckless/9403
2012-12-30Fix double text rendering if using parentRelativeVladimir A. Pavlov1-2/+0
2012-12-30Set WM_WINDOW_ROLE for fluxbox windowsVladimir A. Pavlov2-0/+9
2012-12-11Fixed bug: use expanded style/theme filenameMathias Gumz1-1/+2
'filename' might contain a '~' which has to be expanded to work for regular system calls. We expanded 'filename' already but then did not use it. Fixes bug #3576586.
2012-11-08Rewrite of FbTk::TextureRenderMathias Gumz2-1130/+634
* much more readable and easier to read code * smaller code * reduced binary size due to removed big lookup-table for square root * simple 'optimizations (lookup tables, packing of data), nothing too fancy
2012-10-03Improved vertical alignment of text in FbTk::TextButtonMathias Gumz4-65/+109
The old formula for vertical align text inside FbTk::TextButton ('height/2 + font_ascent/2 - 1') produced not always good looking results, escpecially when different fonts are involved (eg, ClockTool and WorkspaceName have different fonts and font-sizes). '(height - font_ascent) / 2 - 1' produces better results. Additional changes: * added ASCII-Art to document the involved entities when calculating the baseline * rewritten tests/testFont.cc to accept multiples texts and multiple fonts * removed some internal parts of FbTk::Font from the public interface
2012-09-14removed duplicate function signature for FbTk::StringUtil::extractNumber()Mathias Gumz1-1/+1
2012-09-14minor cosmeticMathias Gumz1-4/+2
2012-09-14Fix regression: switch back to microseconds for DelayCmdMathias Gumz2-8/+12
2012-09-14Fix bug: (re)setting timeouts on a running FbTk::Timer might lead to broken ↵Mathias Gumz1-0/+9
timer list Setting a new timeout on a running FbTk::Timer must remove it from the timerlist, otherwise the list is not ordered correctly anymore. So, we stop the running FbTk::Timer, set the new timeout and restart it.
2012-08-28changed timing functions to use a monotonic increasing clockMathias Gumz7-191/+264
gettimeofday() is subject to be changed on daylight-saving or to ntp-related (think leap-seconds). even worse, it is subject to be changed BACK in time. this is hard to fix correctly (see commit 45726d3016e and bug #3560509). it is irrelevant for timers to know the nano-seconds since the epoch anyways.
2012-08-03Add menu.hilite.font and menu.hilite.justify style resourcesVladimir A. Pavlov3-20/+37
2012-08-03FbTk/ThemeItems.cc: move loading additional font resources to load()Vladimir A. Pavlov1-24/+20
The same logic had been already implemented for texture resources.
2012-08-03FbTk/ThemeItems.cc: don't use style resources in ↵Vladimir A. Pavlov1-16/+2
ThemeItem<Font>::setDefaultValue()
2012-04-10removed 'always-true' expressionPaul Tagliamonte1-1/+1
2012-04-10use the 'z' modifier for printing 'size_t' like variablesPaul Tagliamonte1-2/+2
2012-04-10Bugfix: Don't draw the interlace lines 1px too farMathias Gumz1-1/+1
2012-04-06Allow percentage values for some Window commandsLajos Koszti4-0/+89
2012-01-04FbTk/XrmDatabaseHelper.hh: operator== can be const.Ryan Pavlik1-1/+1
Found with cppcheck.
2012-01-04Check .empty() instead of .size() == 0Ryan Pavlik1-2/+2
Found with cppcheck.
2012-01-04Pre-increment non-primitive types.Ryan Pavlik6-9/+9
Found with cppcheck: "Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code."
2012-01-04No need to check if a pointer is null before de-allocating it.Paul Tagliamonte1-2/+1
5.3.5/2 of the C++ standard: "In either alternative, if the value of the operand of delete is the null pointer the operation has no effect."
2011-10-31src/Makefile.am,FbTk/StringUtil.cc: Search relative to the executable.Ryan Pavlik1-0/+65
On Windows, prepend /DUMMYPREFIX to default paths, and replace it at runtime with the prefix relative to the exe directory.
2011-10-31FbTk/StringUtil.cc: Don't return mid-routine.Ryan Pavlik1-2/+3
Prep for Windows dummy prefix code.
2011-10-31main.cc,FbTk/StringUtil.cc: On windows, use USERPROFILE instead of HOMERyan Pavlik1-0/+4
2011-10-31FbTk/FbString.cc,Font.cc: Windows doesn't have nl_langinfoRyan Pavlik2-4/+4
2011-10-31FbTk/Timer.cc: Check HAVE_SYS_SELECT_H, add alternate for windowsRyan Pavlik1-0/+2
2011-10-31Merge branches 'fix-out-of-range-memory', 'obey-configure' and ↵Ryan Pavlik5-11/+29
'other-improvements' into windows-mingw
2011-10-31FbTk/App.cc: make startup failure easier to diagnoseRyan Pavlik1-2/+7
2011-10-31FbTk/FileUtil.cc: Use only file masks defined.Ryan Pavlik1-3/+8
Needed for mingw-cross-env
2011-10-31FbTk/SignalHandler.cc: Use HAVE_SIGACTION, with signal() fallbackRyan Pavlik1-1/+7
This fixes platforms without sigaction, like Windows.
2011-10-31FbTk/Timer.cc: Check HAVE_SYS_SELECT_HRyan Pavlik1-1/+3
2011-10-31FbTk/StringUtil.cc: Fix out-of-range memory access.Ryan Pavlik1-1/+1
if pos is not npos, it will always be less than filename.size(). However, the access later is only safe if there is a character after pos, which would require pos + 1 to be less than filename.size.
2011-10-31FbTk/I18n.cc: Constructor should also check defined(NLS)Ryan Pavlik1-4/+4
2011-10-23bugfix: use the imlib cache for every imlib context usedMathias Gumz1-5/+5
calling imlib_set_cache_size() before a context is created by fluxbox creates an 'unknown' context. that one is never freed at shutdown.
2011-10-23clean up imlib2 loaders at shutdownMathias Gumz1-0/+2
2011-10-23clean up resources on shutdownMathias Gumz1-10/+12
2011-10-23small code simplificationMathias Gumz1-73/+68
2011-10-22Bugfix: clean up static resources correctlyMathias Gumz2-13/+11
93924af160ea303c94a2576b0e57a04e94c9228c might corrupt memory with gcc-4.6.1 when finishing fluxbox (clicking 'exit', sending it a SIGINT). Allthough the order, in which static / global objects are initialized is undefined (at least between separate compilation units), the order in which they are destroyed is well defined: in reverse order of initialization. this means, that if 'ScreenImlibContextContainer contexts' (of ImageImlib2.cc) gets initialized AFTER 'ImageImlib2 imlib2_loader' of Image.cc, it gets destroyed before imlib2_loader. When that happens, ~ImageImlib2() works on a destroyed object. (That lead to '* glibc detected * fluxbox: corrupted double-linked list: 0x0000000000dd2710 ***' later on in 'iconv_close')
2011-10-20Added support for ARGB visual, patch #3284774Gediminas Liktaras2-13/+30
fluxbox now properly displays windows that require ARGB visuals when an external compositor is running. This was done by creating the container window with the correct visual and colormap when needed. Closes #2874629
2011-09-14Enable connecting to const SignalsPavel Labath1-17/+19
The idea is that connecting to a signal doesn't change it's state or the state of the object owning the signal (even though it needs to add the functor to the list for later reference). Emitting, on the other hand, is usually done as a result of a state change and therefore remains non-const. Additional benefit of this arrangement is that objects can export const references to signals to allow connecting, while keeping the ability to emit to themselves.
2011-09-14Add explicit ReturnType cast to operator() of FbTk::SlotsPavel Labath1-4/+5
without this it wasn't possible to construct a Slot returning void from functors returning some real value because the compiler would complain about "return statement with a value in a function returning void". Theoretically, this may produce some unexpected type conversions, because static_cast is slightly stronger than implicit cast, but I judge the risk to be negligable (the alternative would be to provide explicit specializations for slots returning void - too much typing)
2011-09-14Upgrade FbTk::Timer so it can take an arbitrary functor as a parameterPavel Labath2-2/+20
2011-09-14Rename Signal::connect function taking an already-constructed slot to ↵Pavel Labath1-7/+7
connectSlot I do this to avoid compiler ambiguity between the two versions of connect()
2011-09-14Add comparison operators to FbTk::RefCountPavel Labath1-0/+30
without them, gcc would compare them by converting them to bool first, which is not exactly what one would expect. Frankly, I'm surprised it even worked without this.
2011-09-14Remove the assignment operator from a regular pointer to a RefCountPavel Labath3-9/+7
it is too easy too shoot yourself in the foot with it, other smart pointers also don't allow such assignments. If you do want to assign to a RefCount pointer, use reset(). ps: assignment between two RefCounts remains possible, of course.