aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2015-02-07BoyscoutingMathias Gumz2-4/+0
2015-02-07Fix cleaning exposed menu itemsMathias Gumz1-30/+24
2015-02-07Avoid signed/unsigned woes; minor cleanupMathias Gumz1-80/+64
2015-02-06Add uncommited #include "MenuSearch.hh"Mathias Gumz1-0/+1
Note to myself: less gitting at late hours.
2015-02-05Update documentation to reflect menu search optionsMathias Gumz1-0/+11
2015-02-05Cleanup; Remove unused functionMathias Gumz3-9/+1
2015-02-05Feature: different MenuSearch modesMathias Gumz8-149/+298
Fluxbox now supports three MenuSearch modes: * NoWhere - essentially "disabling" the menu search. * Somewhere - the search string matches somewhere. * ItemStart - the search string matches at the start of a menu item. The default value is "ItemStart", just in the good old times. As long as this feature is not configurable via the menu it would irritate users with distinct muscle memory who type without thinking OR checking the visual feedback: they would trigger items they did not intent to trigger after years of the old behavior. Once this feature get's an entry in the config menu the default value might change.
2015-02-04Fix problem with too small WinButtonsMathias Gumz1-53/+71
Under some circumstances a WinButton might be tiny (1x1 pixel). Substracting values > 1 yields either 0 or something reaaaaly big (UINT_MAX). This will make fluxbox either crash or make it act weird. We don't want this.
2015-02-04Move nls globals into #ifdef NLSMathias Gumz1-3/+8
2015-02-01Fix crash: click the Remember-menu works againMathias Gumz1-1/+1
This commit fixes a subtle regression introduced by myself in f64727ca: WinClient wc = FbMenu::window()->winclient() creates a copy and this copy gets cleaned up at the end of the scope. What I really wanted was a reference.
2015-02-01Fix regression: use proper texture for the gripsMathias Gumz1-10/+8
2015-02-01CosmeticMathias Gumz5-24/+25
2015-01-31Close to 1.3.7Mathias Gumz2-0/+30
2015-01-31Improve I18n supportMathias Gumz6-68/+134
Among the first steps to produce better i18n support is to test the created translations adhoc without running "make install". To achieve this, fluxbox now honors several environment variables: - NLSPATH: fluxbox won't create the absolute path to the catalog and thus catopen() is free to use NLSPATH as described in the manpage. Example given: "/tmp/%N" will pick "/tmp/fluxbox.cat". %N refers to FLUXBOX_CATFILE. - FLUXBOX_CATFILE: By setting FLUXBOX_CATFILE the users can make fluxbox to use a different name for the catalog file. Default: "fluxbox.cat" - FLUXBOX_CATDIR: Per default fluxbox tries to find FLUXBOX_CATFILE at several places. Setting this environment variable allows to point fluxbox to a different search path for the catalog files. Then, fluxbox tries catopen() first without changing the deduced catalog file name. After that it applies some heuristics to get a good catalog file name.
2015-01-31Update translations: add CommonDefaultWindowMenuFileMathias Gumz36-174/+193
2015-01-31Clean up FbTk::I18n APIMathias Gumz5-136/+108
Move private stuff into FbTk/I18n.cc.
2015-01-30Fix sometimes missing windowmenuMathias Gumz1-0/+1
When the windowmenu file is empty in ~/.fluxbox/init the code falls back to the default. In ab2eef4 I forgot to set the rc_path which caused this bug to happen.
2015-01-29Add chrome* to fluxbox-generate_menuMathias Gumz1-2/+4
2015-01-29Use strncpy() instead of strcpy()Mathias Gumz1-1/+1
2015-01-29Use strncpy() instead of strcpy()Mathias Gumz1-1/+1
2015-01-29Make fluxbox strcat() freeMathias Gumz1-39/+41
Again, gcc-4.2.1 of OpenBSD-5.6 pointed out the use of strcat(). I took the chance to explain the reasons for the code a little bit.
2015-01-29Simpler code to set _NET_DESKTOP_NAMESMathias Gumz1-9/+3
gcc-4.2.1 on OpenBSD-5.6 hinted that strcpy() is not the safest function on earth. While seeing the code I wondered why it we first create copies of the names at all (let alone using memset() and then strcpy() after it).
2015-01-28Compiler boyscouting: init orderMathias Gumz1-4/+4
2015-01-28Fix correctness of string searchMathias Gumz1-1/+1
The lookup for the skip value needs to be based upon the lowercase version of the current byte.
2015-01-28Increase verbosity of 'configure' summaryMathias Gumz1-2/+5
After 'configure' finishes it states just CXXFLAGS and LIBS. But these are actually not complete, the build system will use much more later on. Problems with the build system are easier to address if 'configure' is a little bit more verbose.
2015-01-28Fix mishandled [maxmized] statement in apps fileMathias Gumz2-246/+248
In f64727ca I removed one 'else' too much. As a result all [maximized] lines were mapped to MAX_NONE. Fixed. The rest of the commit is just some cosmetic to reduce indentation and shorten function names, easier to read.
2015-01-28Feature: typeahead in menu matches text anywhereMathias Gumz10-552/+384
This commit implements a tweak to the typeahead feature already existent in fluxbox: If the user opens up a menu and starts typing, fluxbox tries to detect matching menu items and makes them available for quick selection. The typed pattern is now search also in the middle of the text. I opted to strip down the code quite a bit and remove complexity by throwing out FbTk::TypeAhead and FbTk::SearchResult because I do not see the need for a general solution when the only use case for such a feature is in fluxbox' menus. FbTk::ITypeAheadable shrunk down to 2 functions; the whole file might be combined with the code that implements FbTk::Menu::TypeSearch. FbTk::Menu::setIndex() and related code is also gone: the position of each menu item is defined by it's position in the items container. This reduces the mount of book keeping fluxbox has to do. Fewer moving parts is a good thing. It's possible that users start to complaint because they expect their typed pattern to match only at the beginning of the text OR that some demand other tweaks. We will see. This commit also fixes a regression introduced by 8387742c. The bug made the menu vanish.
2015-01-25Fix printf bug in fluxbox-generate_menuDaniel Campbell1-4/+4
2015-01-24Add 'lxterminal' and 'geany' to fbgmMathias Gumz1-2/+2
Implements #305 (feature request "Recognize lxterminal and geany (fluxbox-generate_menu)"
2015-01-24Update Changelog; prepare 1.3.7Mathias Gumz3-1/+5
2015-01-24CleanupMathias Gumz2-60/+62
2015-01-24Improve code documentationMathias Gumz2-16/+24
'width' might imply something 'aligned horizontally'. The first parameter of maxTextLength() is given in pixels. To avoid confusion, the name of the parameter is changed. The comment before the binary search reflects better why and what we need to do.
2015-01-24Fix text rendering in rotated TextButtonsMathias Gumz1-5/+12
A vertically rotated text should be checked against the height of the button, not the width of it. Fixes #1119 ("Toolbar cannot display full text of workspace/​clock/​window title.")
2015-01-23Refactor Toolbar.cc, less noiseMathias Gumz1-148/+80
2015-01-23Refactor FbWinFrameMathias Gumz2-519/+321
FbWinFrame is now simpler to read due to less overall noise.
2015-01-23CosmeticMathias Gumz3-12/+5
2015-01-22Update manpage to reflect -no-slit and -no-toolbarMathias Gumz2-1/+17
2015-01-22Update translations to reflect new flags via -hMathias Gumz36-38/+185
2015-01-22Add -no-slit and -no-toolbar flagsMathias Gumz6-260/+265
Sometimes fluxbox is used as a component of a desktop environment ( e.g., the "Lumina Desktop"). It's easier and more stable for this kind of "users" to disable the toolbar or the slit alltogether. Why not configure these features out? Because then they would need 2 installations of fluxbox: One without the slit and the toolbar (and perhaps other components) and one with them. This implements feature request #314, at least partially. This commit also looks bigger than it actually is: I refactored and cleaned up classes Fluxbox and BScreen.
2015-01-22Prepare 1.3.7Mathias Gumz22-45/+63
2015-01-22Remove 'always true' conditionMathias Gumz1-1/+1
2015-01-22Fix broken _NET_REQUEST_FRAME_EXTENTS supportMathias Gumz3-14/+20
There was a subtle flaw in the way fluxbox detects to which BScreen a given Window belongs: We have to compare the RootWindow of the given Window against the RootWindow of each BScreen. That underlying flaw made _NET_REQUEST_FRAME_EXTENTS fail: the code path needs a valid BScreen for the given window, otherwise we return early. Closes #1121.
2015-01-22Fix removing windows from icon listMathias Gumz1-3/+3
std::remove_if() removes an item from a container and returns a past-the-end iterator ... which equals m_icon_list.end(). As a result the check if (erase_it != m_icon_list.end()) { iconList().erase(erase_it); iconListSig().emit(*this); } will never succeed and thus the iconListSig() will never be emitted.
2015-01-22CosmeticMathias Gumz4-45/+12
2015-01-21CosmeticMathias Gumz2-5/+14
2015-01-21Fix segfault on shutdownMathias Gumz5-61/+29
There was a problem deep within how the menus were connected and when and what gets deleted. It was clearly related to a menu which was kind of global. In order to better understand the code flow I eliminated the ExtraMenu code: it was used only to get the Remember-Menu into the Window-Menu. Instead of having a singleton of the Remember-Menu and fight against the shaky interconnections we just create a new one on demand and delete when the menu gets deleted. Looks like this fixes the problem. The menu code needs more love anyway. Closes #1118
2015-01-21Refactor: bundle related members togetherMathias Gumz2-220/+211
Also: try to avoid unsigned/signed problems in drawing code.
2015-01-21Cosmetic: less code bloatMathias Gumz1-69/+57
2015-01-21Fix potential memory leakMathias Gumz1-11/+3
If allocation of I2 does not succeed, we need to free I1. Closes #1120
2015-01-21Fix behavior for autorepeat keysMathias Gumz2-2/+13
This reverts 58e09b719077605efadac9b712acb8f5e752f732 after having regressions and bug reports in regards to autorepeated key events are not working anymore. So, the problem with the lost keypress after the workspace change is still open but at least the behavior for other folks is as it was. Since 58e09b7190 seems to be corelated to "auto repeat" keys it might indicate the problem which 58e09b7190 "fixed". We will see. Fixes #1115.