6 files changed, 35 insertions, 29 deletions

diff --git a/src/FbTk/FbString.cc b/src/FbTk/FbString.cc
index 2bc7516..9c7fca7 100644
--- a/src/FbTk/FbString.cc
+++ b/src/FbTk/FbString.cc
@@ -168,6 +168,10 @@ void init() {
     s_inited = true;
     setlocale(LC_CTYPE, "");
 
+    for (int i = 0; i < CONVSIZE; i++) {
+        s_iconv_convs[i] = ICONV_NULL;
+    }
+
 #ifdef HAVE_ICONV
 #if defined(CODESET) && !defined(_WIN32)
     s_locale_codeset = nl_langinfo(CODESET);
@@ -186,8 +190,6 @@ void init() {
     s_iconv_convs[X2FB] = iconv_open("UTF-8", "ISO8859-1");
     s_iconv_convs[FB2LOCALE] = iconv_open(s_locale_codeset.c_str(), "UTF-8");
     s_iconv_convs[LOCALE2FB] = iconv_open("UTF-8", s_locale_codeset.c_str());
-#else
-    memset(s_iconv_convs, 0, sizeof(s_iconv_convs));
 #endif // HAVE_ICONV
 
 }
@@ -195,11 +197,13 @@ void init() {
 void shutdown() {
 #ifdef HAVE_ICONV
     int i;
-    for (i = 0; i < CONVSIZE; ++i)
-        if (s_iconv_convs[i] != ICONV_NULL)
+    for (i = 0; i < CONVSIZE; ++i) {
+        if (s_iconv_convs[i] != ICONV_NULL) {
             iconv_close(s_iconv_convs[i]);
+            s_iconv_convs[i] = ICONV_NULL;
+        }
+    }
 
-    memset(s_iconv_convs, 0, sizeof(s_iconv_convs));
     s_inited = false;
 #endif // HAVE_ICONV
 }
diff --git a/src/FbTk/Layer.hh b/src/FbTk/Layer.hh
index 536ce00..ed28ec6 100644
--- a/src/FbTk/Layer.hh
+++ b/src/FbTk/Layer.hh
@@ -43,7 +43,7 @@ public:
     //typedef std::list<LayerItem *>::reverse_iterator reverse_iterator;
 
     void setLayerNum(int layernum) { m_layernum = layernum; };
-    int  getLayerNum() { return m_layernum; };
+    int  getLayerNum() const { return m_layernum; };
     // Put all items on the same layer (called when layer item added to)
     void alignItem(LayerItem &item);
     int countWindows();
diff --git a/src/FbTk/MenuSearch.cc b/src/FbTk/MenuSearch.cc
index d87bfaf..689323c 100644
--- a/src/FbTk/MenuSearch.cc
+++ b/src/FbTk/MenuSearch.cc
@@ -19,7 +19,7 @@ size_t search_str_textstart(const std::string& text, const std::string& pattern)
 
     size_t i;
     for (i = l; i > 0; i--) {
-        if (std::tolower(text[i-1]) != std::tolower(pattern[i-1])) {
+        if (std::tolower(text[i-1]) != pattern[i-1]) {
             return std::string::npos;
         }
     }
@@ -40,12 +40,13 @@ size_t search_str_bmh(const std::string& text, const std::string& pattern) {
         return std::string::npos;
     }
 
-    size_t t;
-    size_t tlen = text.size();
+    const size_t tlen = text.size();
+    const size_t plen = pattern.size();
+    size_t t; // index in text
 
     // simple case, no need to be too clever
-    if (pattern.size() == 1) {
-        int b = std::tolower(pattern[0]);
+    if (plen == 1) {
+        int b = pattern[0];
         for (t = 0; t < tlen; t++) {
             if (b == std::tolower(text[t])) {
                 return t;
@@ -54,28 +55,28 @@ size_t search_str_bmh(const std::string& text, const std::string& pattern) {
         return std::string::npos;
     }
 
-
-    size_t plast = pattern.size() - 1;
-    size_t p;
-
     // prepare skip-table
     //
-    size_t skip[256];
+    size_t       skip[256];
+    const size_t pe = plen - 1; // end index in pattern
+    size_t       p;             // index in pattern
+
     for (p = 0; p < sizeof(skip)/sizeof(skip[0]); p++) {
-        skip[p] = plast + 1;
+        skip[p] = plen;
     }
-    for (p = 0; p < plast; p++) {
-        skip[std::tolower(pattern[p])] = plast - p;
+    for (p = 0; p < pe; p++) {
+        skip[pattern[p]] = pe - p;
     }
 
     // match
-    for (t = 0; t + plast < tlen; ) {
-        for (p = plast; std::tolower(text[t+p]) == std::tolower(pattern[p]); p--) {
+    //
+    for (t = 0; (t+pe) < tlen; ) {
+        for (p = pe; std::tolower(text[t+p]) == pattern[p]; p--) {
             if (p == 0) {
-                return t+p;
+                return t;
             }
         }
-        t += skip[std::tolower(text[t+p])];
+        t += skip[std::tolower(text[t+pe])];
     }
 
     return std::string::npos;
@@ -117,7 +118,7 @@ void MenuSearch::clear() {
 }
 
 void MenuSearch::add(char c) {
-    pattern.push_back(c);
+    pattern.push_back(std::tolower(c));
 }
 
 void MenuSearch::backspace() {
diff --git a/src/FbTk/MenuSearch.hh b/src/FbTk/MenuSearch.hh
index d642929..e06b39b 100644
--- a/src/FbTk/MenuSearch.hh
+++ b/src/FbTk/MenuSearch.hh
@@ -13,9 +13,10 @@ class MenuItem;
 // a small helper which applies search operations on a list of MenuItems*.
 // the former incarnation of this class was FbTk::TypeAhead in combination with
 // the now non-existent FbTk::SearchResults, but the complexity of these
-// are not needed for our use case. as a bonus we have less lose parts
+// are not needed for our use case. as a bonus, we have less lose parts
 // flying around.
-
+//
+// MenuSearch is case insensitive.
 class MenuSearch {
 public:
 
diff --git a/src/FbTk/StringUtil.hh b/src/FbTk/StringUtil.hh
index b3908d8..2f7c6fc 100644
--- a/src/FbTk/StringUtil.hh
+++ b/src/FbTk/StringUtil.hh
@@ -98,10 +98,10 @@ static void stringTokensBetween(Container &container, const std::string &in,
         const char *ok_chars = " \t\n", bool allow_nesting = true) {
 
     std::string token;
-    int err = 0, pos = 0;
+    int pos = 0;
 
     while (true) {
-        err = getStringBetween(token, in.c_str() + pos, first, last, ok_chars,
+        int err = getStringBetween(token, in.c_str() + pos, first, last, ok_chars,
                                allow_nesting);
         if (err <= 0)
             break;
diff --git a/src/FbTk/TextBox.hh b/src/FbTk/TextBox.hh
index 7b42bd1..40a7c3c 100644
--- a/src/FbTk/TextBox.hh
+++ b/src/FbTk/TextBox.hh
@@ -63,7 +63,7 @@ public:
     const Font &font() const { return *m_font; }
     GC gc() const { return m_gc; }
     int cursorPosition() const { return m_cursor_pos; }
-    int textStartPos(){ return m_start_pos; }
+    int textStartPos() const { return m_start_pos; }
 
     unsigned int findEmptySpaceLeft();
     unsigned int findEmptySpaceRight();