code simplification

we do not need a std::map just to store an attribute on an AtomHandler,
it makes housekeeping just more annoying.

7 files changed, 56 insertions, 62 deletions

diff --git a/src/AtomHandler.hh b/src/AtomHandler.hh
index aa38ed2..6e517d0 100644
--- a/src/AtomHandler.hh
+++ b/src/AtomHandler.hh
@@ -23,6 +23,7 @@
 #ifndef ATOMHANDLER_HH
 #define ATOMHANDLER_HH
 
+#include <string>
 #include <X11/Xlib.h>
 
 class FluxboxWindow;
@@ -61,6 +62,10 @@ public:
 
     /// should this object be updated or not?
     bool update() const { return m_update; }
+
+    void setName(const std::string& name) { m_name = name; }
+    const std::string& getName() const { return m_name; }
+
 protected:
     AtomHandler():m_update(true) { }
 
@@ -68,6 +73,7 @@ protected:
     void enableUpdate() { m_update = true; }
 private:
     bool m_update; ///< do we get update or not
+    std::string m_name; ///< name of atomhandler
 };
 
 #endif // ATOMHANDLER_HH
diff --git a/src/Ewmh.cc b/src/Ewmh.cc
index c09154d..77581b8 100644
--- a/src/Ewmh.cc
+++ b/src/Ewmh.cc
@@ -477,6 +477,7 @@ enum EwmhMoveResizeDirection {
 };
 
 Ewmh::Ewmh() {
+    setName("ewmh");
     m_net = new EwmhAtoms;
 }
 
diff --git a/src/Gnome.cc b/src/Gnome.cc
index 3c84942..78e8a2f 100644
--- a/src/Gnome.cc
+++ b/src/Gnome.cc
@@ -44,6 +44,7 @@ using std::hex;
 using std::dec;
 
 Gnome::Gnome() {
+    setName("gnome");
     createAtoms();
     enableUpdate();
 }
diff --git a/src/Remember.cc b/src/Remember.cc
index 54b5b0d..ef5e7d9 100644
--- a/src/Remember.cc
+++ b/src/Remember.cc
@@ -617,6 +617,8 @@ Remember::Remember():
     m_pats(new Patterns()),
     m_reloader(new FbTk::AutoReloadHelper()) {
 
+    setName("remember");
+
     if (s_instance != 0)
         throw string("Can not create more than one instance of Remember");
 
diff --git a/src/SystemTray.cc b/src/SystemTray.cc
index 73d8c0d..c145351 100644
--- a/src/SystemTray.cc
+++ b/src/SystemTray.cc
@@ -195,7 +195,8 @@ SystemTray::SystemTray(const FbTk::FbWindow& parent,
 
     m_handler.reset(new SystemTrayHandler(*this));
 
-    fluxbox->addAtomHandler(m_handler.get(), atom_name);
+    m_handler.get()->setName(atom_name);
+    fluxbox->addAtomHandler(m_handler.get());
 
 
     // send selection owner msg
diff --git a/src/fluxbox.cc b/src/fluxbox.cc
index aabdb04..1bc0d13 100644
--- a/src/fluxbox.cc
+++ b/src/fluxbox.cc
@@ -373,17 +373,17 @@ Fluxbox::Fluxbox(int argc, char **argv, const char *dpy_name,
     m_keyscreen = m_mousescreen = m_screen_list.front();
 
 #ifdef USE_NEWWMSPEC
-    addAtomHandler(new Ewmh(), "ewmh"); // for Extended window manager atom support
+    addAtomHandler(new Ewmh()); // for Extended window manager atom support
 #endif // USE_NEWWMSPEC
 #ifdef USE_GNOME
-    addAtomHandler(new Gnome(), "gnome"); // for gnome 1 atom support
+    addAtomHandler(new Gnome()); // for gnome 1 atom support
 #endif //USE_GNOME
     // parse apps file after creating screens (so we can tell if it's a restart
     // for [startup] items) but before creating windows
     // this needs to be after ewmh and gnome, so state atoms don't get
     // overwritten before they're applied
 #ifdef REMEMBER
-    addAtomHandler(new Remember(), "remember"); // for remembering window attribs
+    addAtomHandler(new Remember()); // for remembering window attribs
 #endif // REMEMBER
 
     // init all "screens"
@@ -425,18 +425,9 @@ Fluxbox::~Fluxbox() {
     leaveAll(); // leave all connections
 
     // destroy screens (after others, as they may do screen things)
-    while (!m_screen_list.empty()) {
-        delete m_screen_list.back();
-        m_screen_list.pop_back();
-    }
+    FbTk::STLUtil::destroyAndClear(m_screen_list);
 
-    // destroy atomhandlers
-    for (AtomHandlerContainerIt it= m_atomhandler.begin();
-         it != m_atomhandler.end();
-         it++) {
-        delete (*it).first;
-    }
-    m_atomhandler.clear();
+    FbTk::STLUtil::destroyAndClear(m_atomhandler);
 }
 
 
@@ -470,7 +461,7 @@ void Fluxbox::initScreen(BScreen *screen) {
     for (AtomHandlerContainerIt it= m_atomhandler.begin();
          it != m_atomhandler.end();
          it++) {
-        (*it).first->initForScreen(*screen);
+        (*it)->initForScreen(*screen);
     }
 
     FocusControl::revertFocus(*screen); // make sure focus style is correct
@@ -758,7 +749,7 @@ void Fluxbox::handleEvent(XEvent * const e) {
         // but some special cases like ewmh propertys needs to be checked
         for (AtomHandlerContainerIt it= m_atomhandler.begin();
              it != m_atomhandler.end(); it++) {
-            if ( (*it).first->propertyNotify(*winclient, e->xproperty.atom))
+            if ( (*it)->propertyNotify(*winclient, e->xproperty.atom))
                 break;
         }
     } break;
@@ -927,7 +918,7 @@ void Fluxbox::handleClientMessage(XClientMessageEvent &ce) {
         // it's up to the atomhandler to check that
         for (AtomHandlerContainerIt it= m_atomhandler.begin();
              it != m_atomhandler.end(); it++) {
-            (*it).first->checkClientMessage(ce, screen, winclient);
+            (*it)->checkClientMessage(ce, screen, winclient);
         }
 
     }
@@ -999,8 +990,8 @@ void Fluxbox::update(FbTk::Subject *changedsub) {
     if (fbwin && &fbwin->stateSig() == changedsub) { // state signal
         for (AtomHandlerContainerIt it= m_atomhandler.begin();
              it != m_atomhandler.end(); ++it) {
-            if ((*it).first->update())
-                (*it).first->updateState(*fbwin);
+            if ((*it)->update())
+                (*it)->updateState(*fbwin);
         }
         // if window changed to iconic state
         // add to icon list
@@ -1024,14 +1015,14 @@ void Fluxbox::update(FbTk::Subject *changedsub) {
     } else if (fbwin && &fbwin->layerSig() == changedsub) { // layer signal
         AtomHandlerContainerIt it= m_atomhandler.begin();
         for (; it != m_atomhandler.end(); ++it) {
-            if ((*it).first->update())
-                (*it).first->updateLayer(*fbwin);
+            if ((*it)->update())
+                (*it)->updateLayer(*fbwin);
         }
     } else if (fbwin && &fbwin->dieSig() == changedsub) { // window death signal
         AtomHandlerContainerIt it= m_atomhandler.begin();
         for (; it != m_atomhandler.end(); ++it) {
-            if ((*it).first->update())
-                (*it).first->updateFrameClose(*fbwin);
+            if ((*it)->update())
+                (*it)->updateFrameClose(*fbwin);
         }
 
         // make sure each workspace get this
@@ -1042,14 +1033,14 @@ void Fluxbox::update(FbTk::Subject *changedsub) {
     } else if (fbwin && &fbwin->workspaceSig() == changedsub) {  // workspace signal
         for (AtomHandlerContainerIt it= m_atomhandler.begin();
              it != m_atomhandler.end(); ++it) {
-            if ((*it).first->update())
-                (*it).first->updateWorkspace(*fbwin);
+            if ((*it)->update())
+                (*it)->updateWorkspace(*fbwin);
         }
     } else if (client && &client->dieSig() == changedsub) { // client death
         for (AtomHandlerContainerIt it= m_atomhandler.begin();
              it != m_atomhandler.end(); ++it) {
-            if ((*it).first->update())
-                (*it).first->updateClientClose(*client);
+            if ((*it)->update())
+                (*it)->updateClientClose(*client);
         }
 
         BScreen &screen = client->screen();
@@ -1081,7 +1072,7 @@ void Fluxbox::attachSignals(FluxboxWindow &win) {
     win.dieSig().attach(this);
     for (AtomHandlerContainerIt it= m_atomhandler.begin();
          it != m_atomhandler.end(); ++it) {
-        (*it).first->setupFrame(win);
+        (*it)->setupFrame(win);
     }
 }
 
@@ -1090,7 +1081,7 @@ void Fluxbox::attachSignals(WinClient &winclient) {
 
     for (AtomHandlerContainerIt it= m_atomhandler.begin();
          it != m_atomhandler.end(); ++it) {
-        (*it).first->setupClient(winclient);
+        (*it)->setupClient(winclient);
     }
 }
 
@@ -1109,29 +1100,21 @@ BScreen *Fluxbox::searchScreen(Window window) {
 
 AtomHandler* Fluxbox::getAtomHandler(const string &name) {
     if ( name != "" ) {
-        using namespace FbTk;
-        AtomHandlerContainerIt it = find_if(m_atomhandler.begin(),
-                                            m_atomhandler.end(),
-                                            Compose(bind2nd(equal_to<string>(), name),
-                                                    Select2nd<AtomHandlerContainer::value_type>()));
-        if (it != m_atomhandler.end())
-            return (*it).first;
+
+        AtomHandlerContainerIt it;
+        for (it = m_atomhandler.begin(); it != m_atomhandler.end(); it++) {
+            if (name == (*it)->getName())
+                return *it;
+        }
     }
     return 0;
 }
-void Fluxbox::addAtomHandler(AtomHandler *atomh, const string &name) {
-    m_atomhandler[atomh]= name;
+void Fluxbox::addAtomHandler(AtomHandler *atomh) {
+    m_atomhandler.insert(atomh);
 }
 
 void Fluxbox::removeAtomHandler(AtomHandler *atomh) {
-    for (AtomHandlerContainerIt it= m_atomhandler.begin();
-         it != m_atomhandler.end();
-         ++it) {
-        if ((*it).first == atomh) {
-            m_atomhandler.erase(it);
-            return;
-        }
-    }
+    m_atomhandler.erase(atomh);
 }
 
 WinClient *Fluxbox::searchWindow(Window window) {
@@ -1387,7 +1370,7 @@ void Fluxbox::real_reconfigure() {
     for (AtomHandlerContainerIt it= m_atomhandler.begin();
          it != m_atomhandler.end();
          it++) {
-        (*it).first->reconfigure();
+        (*it)->reconfigure();
     }
 }
 
@@ -1453,39 +1436,39 @@ void Fluxbox::updateFrameExtents(FluxboxWindow &win) {
     AtomHandlerContainerIt it = m_atomhandler.begin();
     AtomHandlerContainerIt it_end = m_atomhandler.end();
     for (; it != it_end; ++it ) {
-        (*it).first->updateFrameExtents(win);
+        (*it)->updateFrameExtents(win);
     }
 }
 
 void Fluxbox::workspaceCountChanged( BScreen& screen ) {
     for (AtomHandlerContainerIt it= m_atomhandler.begin();
          it != m_atomhandler.end(); ++it) {
-        if ((*it).first->update())
-            (*it).first->updateWorkspaceCount(screen);
+        if ((*it)->update())
+            (*it)->updateWorkspaceCount(screen);
     }
 }
 
 void Fluxbox::workspaceChanged( BScreen& screen ) {
     for (AtomHandlerContainerIt it= m_atomhandler.begin();
          it != m_atomhandler.end(); ++it) {
-        if ((*it).first->update())
-            (*it).first->updateCurrentWorkspace(screen);
+        if ((*it)->update())
+            (*it)->updateCurrentWorkspace(screen);
     }
 }
 
 void Fluxbox::workspaceNamesChanged(BScreen &screen) {
     for (AtomHandlerContainerIt it= m_atomhandler.begin();
          it != m_atomhandler.end(); ++it) {
-        if ((*it).first->update())
-            (*it).first->updateWorkspaceNames(screen);
+        if ((*it)->update())
+            (*it)->updateWorkspaceNames(screen);
     }
 }
 
 void Fluxbox::clientListChanged(BScreen &screen) {
     for (AtomHandlerContainerIt it= m_atomhandler.begin();
          it != m_atomhandler.end(); ++it) {
-        if ((*it).first->update())
-            (*it).first->updateClientList(screen);
+        if ((*it)->update())
+            (*it)->updateClientList(screen);
     }
 }
 
@@ -1494,14 +1477,14 @@ void Fluxbox::focusedWindowChanged(BScreen &screen,
                                    WinClient* client) {
     for (AtomHandlerContainerIt it= m_atomhandler.begin();
          it != m_atomhandler.end(); it++) {
-        (*it).first->updateFocusedWindow(screen, client ? client->window() : 0 );
+        (*it)->updateFocusedWindow(screen, client ? client->window() : 0 );
     }
 }
 
 void Fluxbox::workspaceAreaChanged(BScreen &screen) {
     for (AtomHandlerContainerIt it= m_atomhandler.begin();
          it != m_atomhandler.end(); ++it) {
-        if ((*it).first->update())
-            (*it).first->updateWorkarea(screen);
+        if ((*it)->update())
+            (*it)->updateWorkarea(screen);
     }
 }
diff --git a/src/fluxbox.hh b/src/fluxbox.hh
index 6082b25..75b868f 100644
--- a/src/fluxbox.hh
+++ b/src/fluxbox.hh
@@ -106,7 +106,7 @@ public:
     Time getLastTime() const { return m_last_time; }
 
     AtomHandler *getAtomHandler(const std::string &name);
-    void addAtomHandler(AtomHandler *atomh, const std::string &name);
+    void addAtomHandler(AtomHandler *atomh);
     void removeAtomHandler(AtomHandler *atomh);
 
     /// obsolete
@@ -277,7 +277,7 @@ private:
     //default arguments for titlebar left and right
     static Fluxbox *s_singleton;
 
-    typedef std::map<AtomHandler *, std::string> AtomHandlerContainer;
+    typedef std::set<AtomHandler *> AtomHandlerContainer;
     typedef AtomHandlerContainer::iterator AtomHandlerContainerIt;
 
     AtomHandlerContainer m_atomhandler;