Fix segfault on shutdown

There was a problem deep within how the menus were connected and when and
what gets deleted. It was clearly related to a menu which was kind of
global. In order to better understand the code flow I eliminated the
ExtraMenu code: it was used only to get the Remember-Menu into the
Window-Menu. Instead of having a singleton of the Remember-Menu and fight
against the shaky interconnections we just create a new one on demand
and delete when the menu gets deleted. Looks like this fixes the problem.

The menu code needs more love anyway.

Closes #1118

1 files changed, 5 insertions, 5 deletions

diff --git a/src/Remember.cc b/src/Remember.cc
index f946ad0..19ea5f0 100644
--- a/src/Remember.cc
+++ b/src/Remember.cc
@@ -1442,10 +1442,10 @@ void Remember::updateClientClose(WinClient &winclient) {
 
 }
 
-void Remember::initForScreen(BScreen &screen) {
-    // All windows get the remember menu.
-    _FB_USES_NLS;
-    screen.addExtraWindowMenu(_FB_XTEXT(Remember, MenuItemName, "Remember...", "Remember item in menu"),
-                              createRememberMenu(screen));
+void Remember::initForScreen(BScreen &screen) { }
+
+FbTk::Menu* Remember::createMenu(BScreen& screen) {
 
+    return createRememberMenu(screen);
 }
+