diff options
| author | Jim Ramsay <i.am@jimramsay.com> | 2010-07-14 15:36:00 (GMT) |
|---|---|---|
| committer | Jim Ramsay <i.am@jimramsay.com> | 2010-07-14 15:36:00 (GMT) |
| commit | a3b063292c003a32c72859f3eecc92de6e1dd132 (patch) | |
| tree | fee8d5fe84771d328e35087a8b183d123895801b /TODO | |
| parent | 3578d1474180ea151adf20ca745aa4ce3f4b3059 (diff) | |
| download | fluxbox-a3b063292c003a32c72859f3eecc92de6e1dd132.zip fluxbox-a3b063292c003a32c72859f3eecc92de6e1dd132.tar.bz2 | |
bugfix: another crash when cleaning up signals
While 769130f51a8f did fix one issue, it introduced another by changing the
logic related to the new SignalTracker. The original logic (introduced in
9ad388c5bf16) was:
-> in 'leave(Signal)', only call 'disconnect'
-> in 'leaveAll()', call 'disconnect' and 'disconnectTracker'
But 769130f51a8f inverted this, calling 'disconnectTracker' in both cases but
only 'disconnect' in the 'leaveAll()' case, which would leave unattached signals
around after calling 'leave(Signal)'.
This fix not only repairs the logic, but renames the ambiguous 'disconnect'
boolean to something more explicit: 'withTracker'.
Diffstat (limited to 'TODO')
0 files changed, 0 insertions, 0 deletions